internal: Remove skill remove command#192
Merged
peterj merged 1 commit intoagentregistry-dev:mainfrom Feb 19, 2026
Merged
Conversation
The remove command was a stub that printed 'Not implemented yet'. This aligns with the pattern established in fc760bc where we removed stale push commands from agent, mcp, and skill. The delete command is the canonical way to remove skills from the registry.
timflannagan
force-pushed
the
cleanup/remove-skill-remove-command
branch
from
3e272cd to
d32e61b
Compare
peterj
approved these changes
Feb 19, 2026
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
# Description Remove the stub `remove` command from `arctl skill` which only printed "Not implemented yet". MCP and agent subcommands only have `delete` - skill should match that pattern. # Change Type /kind cleanup # Changelog ```release-note NONE ``` # Additional Notes Also updated the help text example to show `delete` instead of `remove`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
# Description - **Motivation:** After deploying an agent or MCP server, the CLI returned immediately without confirming the deployment was actually ready. Users had no way to know if the deployment succeeded. Fixes #192. - **What changed:** - Added `--wait` flag (default `true`) to both `agent deploy` and `mcp deploy` commands - Added `WaitForDeploymentReady` helper in `internal/cli/common/wait.go` that polls deployment status until terminal state or 5-minute timeout - Added `deploy_test.go` with flag registration tests - Removed trivial `TestWaitConstants` test per review feedback # Change Type /kind feature # Changelog ```release-note Add --wait flag to agent deploy and mcp deploy to wait for deployment readiness before returning ``` # Additional Notes - Rebased on latest main to reduce diff noise. - The `--wait` flag defaults to `true` per review feedback (reversed from original `--no-wait` approach). - Local deployments skip the wait since they are handled synchronously. --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: timflannagan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the stub
removecommand fromarctl skillwhich only printed "Not implemented yet". MCP and agent subcommands only havedelete- skill should match that pattern.Change Type
/kind cleanup
Changelog
Additional Notes
Also updated the help text example to show
deleteinstead ofremove.