golangci: Enable testifylint#191
Merged
peterj merged 1 commit intoagentregistry-dev:mainfrom Feb 19, 2026
Merged
Conversation
Enable testifylint to enforce testify best practices. We fix all violations by using require.NoError/require.Error instead of assert for error checks. This is the correct pattern since there's no point continuing a test after an error assertion fails.
peterj
approved these changes
Feb 19, 2026
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
<!-- Thanks for opening a PR! Please delete any sections that don't apply. --> # Description <!-- A concise explanation of the change. You may include: - **Motivation:** why this change is needed - **What changed:** key implementation details - **Related issues:** e.g., `Fixes agentregistry-dev#123` --> Enable testifylint to enforce testify best practices. We fix all violations by using require.NoError/require.Error instead of assert for error checks. This is the correct pattern since there's no point continuing a test after an error assertion fails. This is a linter enabled in a couple of different projects (gateway-api comes immediate to mind). # Change Type <!-- Select one or more of the following by including the corresponding slash-command: ``` /kind breaking_change /kind bump /kind cleanup /kind design /kind deprecation /kind documentation /kind feature /kind fix /kind flake /kind install ``` --> /kind cleanup # Changelog <!-- Provide the exact line to appear in release notes for the chosen changelog type. If no, just write "NONE" in the release-note block below. If yes, a release note is required: --> ```release-note NONE ``` # Additional Notes <!-- Any extra context or edge cases for reviewers. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable testifylint to enforce testify best practices. We fix all violations by using require.NoError/require.Error instead of assert for error checks. This is the correct pattern since there's no point continuing a test after an error assertion fails.
This is a linter enabled in a couple of different projects (gateway-api comes immediate to mind).
Change Type
/kind cleanup
Changelog
Additional Notes