locking down to specific python and dependency versions#189
Conversation
Signed-off-by: Peter Jausovec <[email protected]>
…o suprises when versions change Signed-off-by: Peter Jausovec <[email protected]>
There was a problem hiding this comment.
Are these changes related to the ADK replace pin?
There was a problem hiding this comment.
the requires here is just to be sure -- we do set the version in .python-version file too, but it's clearer if it's here as well (note we depend on 3.13 because of one o the kagent libraries)
pkg/cli/root.go
Outdated
| return c, nil | ||
| } | ||
|
|
||
| func applyAPIClientToSubcommands(c *client.Client) { |
There was a problem hiding this comment.
nit: I'd advocate for moving all of this logic until EIF at the top of the file. Easier to read for cobra-based CLIs where you have the rootCmd that acts as a driver + init() commands.
pkg/cli/root.go
Outdated
| return err | ||
| } | ||
|
|
||
| applyAPIClientToSubcommands(c) |
There was a problem hiding this comment.
Looks like this function is used here & for testing purposes. Can't we inline this instead and skip the unit tests?
pkg/cli/root.go
Outdated
| cli.SetAPIClient(c) | ||
| } | ||
|
|
||
| var rootCmd = &cobra.Command{ |
There was a problem hiding this comment.
We can do this in the future, but some of the globals being used throughout this root package can be dramatically reduced via constructors on each sub-command. Obviously doesn't block these changes though.
Signed-off-by: Peter Jausovec <[email protected]>
|
This has been resolved on the kagent side, we are now unit testing down to |
…y-dev#189) Setting explicit dependency versions for the MCP project and the agent project. Note that the agent project right now requires 3.13, as one of it's dependencies requires is (kagent-skills). We could lower that version later [once this is fixed](kagent-dev/kagent#1329). The first commit also updates CLI so it doesn't try to connect/launch to the daemon when running the init command. Resolves agentregistry-dev#186 --------- Signed-off-by: Peter Jausovec <[email protected]>
3 participants
Setting explicit dependency versions for the MCP project and the agent project. Note that the agent project right now requires 3.13, as one of it's dependencies requires is (kagent-skills). We could lower that version later once this is fixed.
The first commit also updates CLI so it doesn't try to connect/launch to the daemon when running the init command.
Resolves #186