Add test ensuring all CLI commands are registered#137
Closed
joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
Closed
Add test ensuring all CLI commands are registered#137joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
Conversation
Addresses agentregistry-dev#77. Adds TestAllCommandsRegistered which verifies that every expected top-level command and subcommand is present in the cobra command tree. This catches cases where a new command is added to the source but not registered (or vice versa). Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
The lint is failing because the code uses the |
peterj
pushed a commit
that referenced
this pull request
Feb 25, 2026
# Description Add complementary unit tests for CLI command tree structure, flag registration, required flag validation, hidden command detection, and argument count validators. Test coverage includes: - `TestCommandTree` - verifies all 8 top-level commands and subcommand counts - `TestCommandsHaveRequiredMetadata` - walks entire tree checking Use/Short fields - `TestHiddenCommands` - verifies import/export are hidden - `TestAgentInitFlags` - 6 flags with correct defaults - `TestSkillPublishFlags` - 5 flags with defaults + required flag check - `TestRequiredFlags` - 4 commands with required flags validated - `TestRootPersistentFlags` - registry-url and registry-token - `TestArgsValidators` - 16 cases testing ExactArgs/ArbitraryArgs enforcement Uses `slices.Sort` instead of forbidden `sort` package. Fixes #77 # Change Type /kind feature # Changelog ```release-note Add CLI command registration and flag unit tests ``` # Additional Notes - Complementary to PR #137 (stalled on lint failure from `sort` package usage) - Uses `slices.Sort` to comply with `depguard` linter rule - Single new file: `pkg/cli/commands_test.go` (346 lines, 39+ subtests)
|
This pull request has been marked as stale due to no activity in the last 14 days. It will be closed in 3 days unless it is tagged "no stalebot" or other activity occurs. |
|
This pull request has been closed due to inactivity. |
christian-posta
pushed a commit
to christian-posta/agentregistry
that referenced
this pull request
Mar 9, 2026
…-dev#207) # Description Add complementary unit tests for CLI command tree structure, flag registration, required flag validation, hidden command detection, and argument count validators. Test coverage includes: - `TestCommandTree` - verifies all 8 top-level commands and subcommand counts - `TestCommandsHaveRequiredMetadata` - walks entire tree checking Use/Short fields - `TestHiddenCommands` - verifies import/export are hidden - `TestAgentInitFlags` - 6 flags with correct defaults - `TestSkillPublishFlags` - 5 flags with defaults + required flag check - `TestRequiredFlags` - 4 commands with required flags validated - `TestRootPersistentFlags` - registry-url and registry-token - `TestArgsValidators` - 16 cases testing ExactArgs/ArbitraryArgs enforcement Uses `slices.Sort` instead of forbidden `sort` package. Fixes agentregistry-dev#77 # Change Type /kind feature # Changelog ```release-note Add CLI command registration and flag unit tests ``` # Additional Notes - Complementary to PR agentregistry-dev#137 (stalled on lint failure from `sort` package usage) - Uses `slices.Sort` to comply with `depguard` linter rule - Single new file: `pkg/cli/commands_test.go` (346 lines, 39+ subtests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #77. Adds
TestAllCommandsRegisteredinpkg/cli/root_test.gowhich verifies that every expected top-level command and subcommand is present in the cobra command tree.Test plan
go test ./pkg/cli/ -run TestAllCommandsRegistered -vpassesgo test ./pkg/cli/... ./internal/cli/...)go vet ./pkg/cli/clean