-
Notifications
You must be signed in to change notification settings - Fork 45
Description
Related to #377, we currently specify the --fix flag for the lint.yaml GHA workflow for the third party golangci-lint action. This masks actual linting violations. Reproducible off main as well if you use the same version as CI:
$ go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run
go: github.com/golangci/golangci-lint/[email protected] requires go >= 1.24.0; switching to go1.25.8
internal/cli/agent/list_test.go:66:1: File is not properly formatted (gofmt)
name string
^
internal/cli/agent/publish.go:19:1: File is not properly formatted (gofmt)
publishVersion string
^
internal/cli/mcp/publish.go:233:1: File is not properly formatted (gofmt)
GitURL: gitRepository,
^
internal/cli/mcp/publish_test.go:133:1: File is not properly formatted (gofmt)
gitURL string
^
internal/cli/skill/publish.go:23:1: File is not properly formatted (gofmt)
versionFlag string
^
internal/registry/service/testing/fake_registry.go:36:1: File is not properly formatted (gofmt)
ListServersFn func(ctx context.Context, filter *database.ServerFilter, cursor string, limit int) ([]*apiv0.ServerResponse, string, error)
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:428:13: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
if len(vol.VolumeSource.ConfigMap.Items) != 1 || vol.VolumeSource.ConfigMap.Items[0].Key != "prompts.json" {
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:429:78: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
t.Errorf("expected volume to contain only prompts.json item, got %+v", vol.VolumeSource.ConfigMap.Items)
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:479:13: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
if len(vol.VolumeSource.ConfigMap.Items) != 2 {
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:480:55: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
t.Fatalf("expected 2 volume items, got %d", len(vol.VolumeSource.ConfigMap.Items))
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:483:27: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
for _, item := range vol.VolumeSource.ConfigMap.Items {
^
internal/registry/platforms/kubernetes/deployment_adapter_kubernetes_platform_test.go:487:88: QF1008: could remove embedded field "VolumeSource" from selector (staticcheck)
t.Errorf("expected volume items for mcp-servers.json and prompts.json, got %+v", vol.VolumeSource.ConfigMap.ItemsReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done