Repository navigation
fix(agent): enforce repair deadline in flight and thread graph delivery control (#206) - #335
Merged
yuluo-yx merged 2 commits intoOct 30, 2026
Conversation
…ry control (agentic-ai-java#206) The structured-output repair wait is sliced so the remaining deadline is actively enforced while the response is still pending: a request that never returns is cancelled through the onLoss registration once the deadline expires, instead of relying on the control to produce a stop notification or on an external get(timeout). The graph ReactAgent delivery now travels with the run's execution boundaries: the config's own control passes through unchanged, a trusted deadline plus execution guard combine into a delivery-owned control, and a bare guard governs the re-ask directly, so a stop during the callResult/streamResult final repair delivers INTERRUPTED instead of COMPLETED or VALIDATION_FAILED. The unreleased control overload widens from ExecutionControl to the neutral ExecutionGuard so the graph path can bridge without the finalizer depending on graph types.
…ess (agentic-ai-java#206) A bare execution guard whose assertActive throws a plain RuntimeException (the framework's own checkpoint lease throws LeaseLostException) no longer degrades to a marked repair failure or escapes the delivery as an execution error: attemptRepair re-asserts the guard before treating a call failure as the client's own, and the graph delivery boundary re-checks the guard to classify stop-shaped failures as INTERRUPTED. The boundary also asserts liveness before publishing, so an already cancelled, expired or ownership-lost run cannot deliver a COMPLETED output even when the terminal message is schema-valid and needs no repair. ExecutionGuard gains a default deadline() accessor (overridden by ExecutionControl) so the repair wait is sliced only when a deadline actually bounds it — a deadline-less guard goes back to a plain wait instead of polling idle — and the graph bridge reuses the canonical AgentExecutionContext scope instead of re-implementing the wrap. Deterministic regression tests cover a lease-style guard lost during the repair and an expired trusted deadline with a valid terminal.
Contributor
Author
|
Review follow-up pushed (4b0f434), from a self-run two-axis review of the PR diff before requesting another look. Four confirmed defects on paths the first round of tests did not cover, now closed with regression coverage:
Known follow-ups deliberately kept out of this PR (pre-existing, broader than the #206 delivery boundary): the main model call still uses plain Full reactor build green (local; the two |
XianReallyHot-ZZH
deleted the
fix/206-active-repair-deadline-and-graph-control
branch
November 7, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
确认 (Acknowledged) contribution to ARGI: slice the in-flight structured-output repair wait so the remaining deadline actively cancels a never-returning underlying request through the onLoss registration, and thread the graph ReactAgent callResult/streamResult delivery through the run execution boundaries — the config own control passes through, a trusted deadline plus execution guard bridge onto a delivery-owned control, a bare guard governs the re-ask directly — so a stop during the final repair delivers INTERRUPTED instead of COMPLETED or VALIDATION_FAILED, widening the unreleased control overload from ExecutionControl to the neutral ExecutionGuard, for #206.