Repository navigation
fix(agent): keep interruption feedback until it can be applied - #222
Merged
yuluo-yx merged 1 commit intoOct 23, 2026
Merged
Conversation
yuluo-yx
approved these changes
Oct 23, 2026
yuluo-yx
left a comment
Member
There was a problem hiding this comment.
Reviewed deferred feedback handling and conditional consumption with concurrent replacement tests. The frontend dependency audit failure is independent of this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Contributing to ARGI: interruption feedback is no longer lost when
InterruptionHookruns while the last assistant message still has pending tool calls.Does this pull request fix one issue?
Fixes #211
Describe how you did it
remove(key, value)when it is applied.Describe how to verify it
./mvnw -pl :argi-agent-framework -am test(1388 tests pass). NewInterruptionHookTestcases cover deferral and single application, invalid feedback with pending tool calls, and a latch-controlled concurrent write; the deferral and concurrency cases fail on the previous implementation.Special notes for reviews
Cleanup of
ReactAgent.threadIdStateMapentries is out of scope and can be a follow-up. This only covers the in-process feedback path, not persistent approvals (#130).