Repository navigation
fix(agent): detect model failures by marker, not answer text - #221
Merged
yuluo-yx merged 1 commit intoOct 23, 2026
Merged
Conversation
yuluo-yx
approved these changes
Oct 23, 2026
yuluo-yx
left a comment
yuluo-yx
left a comment
Member
There was a problem hiding this comment.
Reviewed the framework failure marker, model-output sanitization and call/stream regression tests. The frontend dependency audit failure is independent of this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Contributing to ARGI:
callResult/streamResultno longer reportMODEL_FAILEDfor normal answers that happen to start withException:.Does this pull request fix one issue?
Fixes #205
Describe how you did it
throwOnModelErroris disabled,AgentLlmNodemarks its substituted failure message with framework metadata (AgentLlmNode.MODEL_FAILURE_METADATA_KEY).ReactAgent.deliverchecks the marker instead of the text prefix, shared by call and stream paths. The legacycallstill returns the originalException: ...message, andthrowOnModelError=truebehavior is unchanged.Describe how to verify it
./mvnw -pl :argi-agent-framework -am test(1390 tests pass). New cases: normal answer with the prefix (call and stream), forged marker (call and stream),throwOnModelError=true, and the legacy call message.Special notes for reviews
New public constant
AgentLlmNode.MODEL_FAILURE_METADATA_KEY. Failure messages now carry this metadata key; no other public API changes.