Repository navigation
fix(studio): keep thread metadata and state updates atomic - #220
Merged
Merged
Conversation
yuluo-yx
approved these changes
Oct 23, 2026
yuluo-yx
left a comment
yuluo-yx
left a comment
Member
There was a problem hiding this comment.
Reviewed the atomic thread record and generation checks with the delete/recreate regression tests. The frontend dependency audit failure is tracked separately from this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Contributing to ARGI: Studio thread metadata and state are stored in one record per key, so create, update and delete can no longer leave orphaned or stale state.
Does this pull request fix one issue?
Fixes #193
Describe how you did it
ThreadServiceImplwith a singleConcurrentHashMap<String, ThreadRecord>; every operation is one atomic map call.updateThreadStateonly applies to the instance it observed, so it is dropped after delete and cannot pollute a re-created thread with the same ID.getThreadStatereturns a copy. HTTP endpoints, DTOs and the encoded key format are unchanged.Describe how to verify it
./mvnw -pl :argi-studio -am test -Dtest=ThreadServiceImplTest. New latch-based tests cover update/delete, delete/recreate and create/delete interleavings; the first two fail on the previous implementation.Special notes for reviews
Storage stays in memory; no database is introduced.