Repository navigation
fix(studio): serialize SSE error events as valid JSON - #219
Merged
Merged
Conversation
yuluo-yx
approved these changes
Oct 23, 2026
yuluo-yx
left a comment
yuluo-yx
left a comment
Member
There was a problem hiding this comment.
Reviewed the SSE serialization and shared reader changes with the regression tests. The failed format job was a Maven download HTTP 429, not a formatting finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Contributing to ARGI: Studio SSE error events are now always valid JSON, and the UI no longer silently drops malformed error events.
Does this pull request fix one issue?
Fixes #192
Describe how you did it
StreamErrorResponsewith the existingObjectMapper, with a constant fallback if serialization fails. Event name and fields (error,errorType,errorMessage) are unchanged.argi-api.tsuses one SSE reader for both streams: an unparsableevent: errornow fails the stream, while malformed normal data lines are still skipped. It also handles CRLF, chunk boundaries and a trailing event without newline.Describe how to verify it
./mvnw -pl :argi-studio -am test(newStudioStreamErrorEventTest: quotes, backslashes, Windows paths, tab, CR, LF, Unicode, null message, serializer failure).pnpm testinargi-studio/agent-chat-ui(15 tests, including split-chunk and malformed error event cases).Special notes for reviews
Bundled static assets under
META-INF/resources/chatuiare not rebuilt in this PR, consistent with previousargi-api.tschanges. No browser end-to-end run.