Repository navigation
mcp tasks support - #2745
Merged
Merged
mcp tasks support#2745
Conversation
Signed-off-by: Steven Landow <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for MCP task methods (SEP-2663) in AgentGateway, including routing, multiplex-safe task IDs, RBAC/CEL integration, and correct capability forwarding across protocol versions.
Changes:
- Routes
tasks/get,tasks/update, andtasks/cancelto the owning upstream by parsing/rewriting task IDs and threads task IDs into theMcp-Nameheader. - Enforces RBAC on task methods via a new
taskresource type and CEL context (mcp.task.*), and rewrites task IDs in upstream responses/notifications for round-tripping. - Updates capability forwarding behavior and adds comprehensive tests covering single-target, multiplexing, legacy vs modern capability stripping, and RBAC denial behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| schema/config.json | Clarifies that McpPrefixMode does not affect task ID namespacing under multiplexing. |
| schema/cel.md | Documents new CEL context fields for mcp.task.*. |
| schema/cel.json | Adds JSON schema entries for mcp.task context object. |
| crates/agentgateway/src/mcp/upstream/openapi/mod.rs | Adjusts OpenAPI upstream behavior for task methods (now treated as invalid params / unknown task). |
| crates/agentgateway/src/mcp/streamablehttp.rs | Ensures Mcp-Name header is derived from task IDs for task methods. |
| crates/agentgateway/src/mcp/session.rs | Implements task-method dispatch, task ID de/multiplexing, and task RBAC checks; refines capability stripping for legacy clients. |
| crates/agentgateway/src/mcp/rbac.rs | Introduces ResourceType::Task into RBAC/CEL dynamic typing. |
| crates/agentgateway/src/mcp/mod.rs | Adds task operation/logging support via MCPOperation::Task and MCPInfo.task. |
| crates/agentgateway/src/mcp/mcp_tests.rs | Adds/extends tests for capability forwarding, task round-trips, multiplexed task IDs, and RBAC denial on task methods. |
| crates/agentgateway/src/mcp/handler.rs | Rewrites task IDs in responses/notifications and adds parsing of namespaced task IDs for multiplex routing. |
| crates/agentgateway/src/cel/types.rs | Extends CEL example executor context to include mcp.task. |
Comments suppressed due to low confidence (1)
schema/cel.json:1004
mcp.task.nameis documented as "The name of the resource" but this field is the task ID. Updating the description will make CEL/RBAC policy intent clearer.
"name": {
"description": "The name of the resource",
"type": "string",
"default": ""
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Steven Landow <[email protected]>
Signed-off-by: Steven Landow <[email protected]>
howardjohn
reviewed
Jul 28, 2026
howardjohn
left a comment
howardjohn
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good at first glance
howardjohn
reviewed
Jul 28, 2026
| .map(|tool| tool.name.as_str()) | ||
| .or_else(|| self.prompt.as_ref().map(ResourceId::name)) | ||
| .or_else(|| self.resource.as_ref().map(ResourceId::name)) | ||
| .or_else(|| self.task.as_ref().map(MCPTask::name)) |
Collaborator
There was a problem hiding this comment.
I think this is a problem name in all the others is a static thing, you probably have like 1-50 tools maybe. We put it in prometheus metric mcp_requests. So we prob need to opt out there... maybe we use it in some places ike CEL and logs but metrics has a different path
Collaborator
Author
There was a problem hiding this comment.
Fixed this. Theoretically we could have this problem with resource templates too, right?
Signed-off-by: Steven Landow <[email protected]>
howardjohn
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2554
note this isn't well supported by the SDKs, it only last week made it into rust-sdk:
so I don't think merging this is super urgent