Skip to content

fix: clear stale entity metadata during ACP v2 replay - #716

Merged
benbrandt merged 1 commit into
mainfrom
fix/replay-entity-metadata
Oct 30, 2026
Merged

benbrandt merged 1 commit into
mainfrom
fix/replay-entity-metadata

Conversation

@benbrandt

Copy link
Copy Markdown
Member

Summary

  • Extend v2 replay initialization from messages to tool calls, terminals, and compactions. The first upsert for each entity explicitly clears retained _meta once per session replay. If the report has current metadata, clear first and then restore that object in a separate update.
  • Apply initialization after v2 conversion, where a command report becomes both terminal and tool updates. Their IDs may match, but they have separate entity namespaces and each needs its own clear.
  • Generalize the existing message-primer send path rather than adding separate reset logic to every reporter. Standard, AIR/native, root, and child history paths share it, including paginated history and repeated replay on the same connection.
  • Keep shared publication fencing and tool-report filtering/tracking before conversion. Completed-tool tracking still suppresses duplicate completions and late output, while subsequent partial and live updates retain normal metadata-patch semantics.
  • Leave chunk metadata, plan metadata, session-level metadata, and v1 wire behavior unchanged. Only three existing v2 snapshots gain the intended metadata clears.

Checked against ACP 8eb7e749, especially docs/protocol/v2/extensibility.mdx:103-150 and docs/protocol/v2/session-setup.mdx:312-317. Replay does not implicitly reset metadata. Empty current metadata requires _meta: null; a nonempty replacement needs an explicit clear before the current object when stale keys are unknown.

Scope

This is replayed-entity metadata synchronization, not reconstruction of session-wide extension metadata or other omitted entity fields. Session-level metadata remains separate because its writers also publish live extension state. The newer upstream auth/status schema and draft additions encountered during the specification refresh are not adopted in this PR. No review/checklist Markdown file is included.

Validation

  • npm run typecheck
  • npm run build
  • npm test: 2,346 passed, 39 skipped
  • npm run test:integration: all 19 passed
  • npm run codex-test -- -p "Reply with exactly OK. Do not use tools or modify any files." -o summary: completed with end_turn
  • git diff --check
  • Opt-in E2E tests were not run.

Tests cover retained metadata removal, restoring current metadata including nested null values, keeping fresh metadata through later status/partial updates, separate tool/terminal identities, preserved message primers, untouched chunk/plan/session metadata, completed-tool filtering and late-output suppression, and post-close publication fencing. Wire tests exercise two replays on one connection across standard/AIR and legacy/paginated history. Existing v1 and child-ordering snapshots remain unchanged.

@benbrandt
benbrandt merged commit 580d8b9 into main Oct 30, 2026
6 checks passed
@benbrandt
benbrandt deleted the fix/replay-entity-metadata branch October 30, 2026 20:46
EugeneTheDev pushed a commit that referenced this pull request Nov 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.6.0](v2.5.0...v2.6.0)
(2026-11-06)


### Features

* expose configured permission profiles as modes
([#395](#395))
([caf2e87](caf2e87))
* predict the follow-up prompt with thread/sample on the session thread
([#740](#740))
([f9cb470](f9cb470))
* show async Codex questions as elicitations
([#707](#707))
([cc57c7e](cc57c7e))
* update ACP SDK to 2.4 and align protocol behavior
([#727](#727))
([ab513aa](ab513aa))


### Bug Fixes

* clear stale entity metadata during ACP v2 replay
([#716](#716))
([580d8b9](580d8b9))
* defer startup interactions until session setup is delivered
([#714](#714))
([ad993bb](ad993bb))
* fence turn interrupt retries to the original prompt
([#723](#723))
([9c33f86](9c33f86))
* match vendor-prefixed gateway model ids such as OpenRouter's
([#731](#731))
([29195ec](29195ec))
* preserve sibling session metadata namespace fields
([#718](#718))
([3720341](3720341))
* publish complete configuration updates for session changes
([#715](#715))
([b7ac0bf](b7ac0bf))
* release the prompt suggestion thread and keep it minimal
([#709](#709))
([82ad58f](82ad58f))
* report verified standard subagent directories
([#722](#722))
([7d7e95a](7d7e95a))
* resynchronize current session metadata on ACP v2 resume
([#717](#717))
([927c480](927c480))
* scope authentication cancellation and initial status delivery
([#720](#720))
([e059ab7](e059ab7))
* show commands in Zed approval prompts
([#735](#735))
([cca2dca](cca2dca))
* skip the app-server restart when providers/set repeats the applied
config
([#728](#728))
([3b35338](3b35338))
* start the Codex app-server with the provider of the gateway routing
([#733](#733))
([cbcd446](cbcd446))
* suppress session messages after close
([#712](#712))
([85bf932](85bf932))
* synchronize resumed titles and reset replayed message metadata
([#713](#713))
([ef45a6d](ef45a6d))
* tear down session interactions and background processes on close
([#711](#711))
([1e89efa](1e89efa))
* update ACP SDK to 2.2 and align protocol behavior
([#710](#710))
([6f96fbe](6f96fbe))
* update codex to 0.166.0
([#734](#734))
([e53f23e](e53f23e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant