Repository navigation
feat: expose configured permission profiles as modes - #395
Merged
EugeneTheDev merged 2 commits intoNov 3, 2026
Merged
EugeneTheDev merged 2 commits into
EugeneTheDev merged 2 commits into
Conversation
tpansino
force-pushed
the
feat/permission-profile-modes
branch
from
August 14, 2026 23:19
f757ba2 to
2ce2ee5
Compare
tpansino
force-pushed
the
feat/permission-profile-modes
branch
3 times, most recently
from
August 31, 2026 04:35
3e3768d to
073b73d
Compare
This was referenced Sep 7, 2026
tpansino
force-pushed
the
feat/permission-profile-modes
branch
2 times, most recently
from
September 9, 2026 21:31
44864a8 to
ec78a90
Compare
tpansino
force-pushed
the
feat/permission-profile-modes
branch
from
September 16, 2026 05:05
ec78a90 to
7455eef
Compare
tpansino
force-pushed
the
feat/permission-profile-modes
branch
from
September 28, 2026 23:59
7455eef to
e722753
Compare
tpansino
force-pushed
the
feat/permission-profile-modes
branch
2 times, most recently
from
October 12, 2026 18:42
65f042e to
d419f41
Compare
tpansino
force-pushed
the
feat/permission-profile-modes
branch
from
October 22, 2026 20:36
d419f41 to
d5deb06
Compare
Contributor
Author
|
@nikita-ashihmin @EugeneTheDev @slapoguzov could one of you take a look at this please? And sorry for the direct ping, I didn't find any other documented method for contacting maintainers. |
EugeneTheDev
self-requested a review
October 29, 2026 20:32
EugeneTheDev
requested changes
Oct 29, 2026
tpansino
force-pushed
the
feat/permission-profile-modes
branch
from
November 1, 2026 20:48
d5deb06 to
4427f10
Compare
EugeneTheDev
requested changes
Nov 2, 2026
EugeneTheDev
left a comment
Collaborator
There was a problem hiding this comment.
There's an edge case with session/load / session/resume, check the comments
nyssance
added a commit
to nyssance/codex-acp
that referenced
this pull request
Nov 4, 2026
…profile modes, Codex 0.166 Merges agentclientprotocol/codex-acp agentclientprotocol#727, agentclientprotocol#395, agentclientprotocol#728, agentclientprotocol#731, agentclientprotocol#733, agentclientprotocol#734 and agentclientprotocol#609. - Permission profiles follow upstream agentclientprotocol#395: profiles are listed when a session opens and offered as `permission-profile:<id>` modes. The fork keeps its custom-permissions mode, restoring the thread's own permissions, and applies a mode change to the thread immediately. - An unknown INITIAL_AGENT_MODE still fails instead of falling back. - `_session/rename` and `_codex/session_rename` share the standard `session/set_title` path. - Provider updates restart the app-server when its startup routing changed, even with no open session. - Real Codex fixtures honor CODEX_PATH. - Generated app-server types stay on the fork's experimental generation. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RaizxxJBbHnYoG9L4g1u5b
EugeneTheDev
pushed a commit
that referenced
this pull request
Nov 8, 2026
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.0...v2.6.0) (2026-11-06) ### Features * expose configured permission profiles as modes ([#395](#395)) ([caf2e87](caf2e87)) * predict the follow-up prompt with thread/sample on the session thread ([#740](#740)) ([f9cb470](f9cb470)) * show async Codex questions as elicitations ([#707](#707)) ([cc57c7e](cc57c7e)) * update ACP SDK to 2.4 and align protocol behavior ([#727](#727)) ([ab513aa](ab513aa)) ### Bug Fixes * clear stale entity metadata during ACP v2 replay ([#716](#716)) ([580d8b9](580d8b9)) * defer startup interactions until session setup is delivered ([#714](#714)) ([ad993bb](ad993bb)) * fence turn interrupt retries to the original prompt ([#723](#723)) ([9c33f86](9c33f86)) * match vendor-prefixed gateway model ids such as OpenRouter's ([#731](#731)) ([29195ec](29195ec)) * preserve sibling session metadata namespace fields ([#718](#718)) ([3720341](3720341)) * publish complete configuration updates for session changes ([#715](#715)) ([b7ac0bf](b7ac0bf)) * release the prompt suggestion thread and keep it minimal ([#709](#709)) ([82ad58f](82ad58f)) * report verified standard subagent directories ([#722](#722)) ([7d7e95a](7d7e95a)) * resynchronize current session metadata on ACP v2 resume ([#717](#717)) ([927c480](927c480)) * scope authentication cancellation and initial status delivery ([#720](#720)) ([e059ab7](e059ab7)) * show commands in Zed approval prompts ([#735](#735)) ([cca2dca](cca2dca)) * skip the app-server restart when providers/set repeats the applied config ([#728](#728)) ([3b35338](3b35338)) * start the Codex app-server with the provider of the gateway routing ([#733](#733)) ([cbcd446](cbcd446)) * suppress session messages after close ([#712](#712)) ([85bf932](85bf932)) * synchronize resumed titles and reset replayed message metadata ([#713](#713)) ([ef45a6d](ef45a6d)) * tear down session interactions and background processes on close ([#711](#711)) ([1e89efa](1e89efa)) * update ACP SDK to 2.2 and align protocol behavior ([#710](#710)) ([6f96fbe](6f96fbe)) * update codex to 0.166.0 ([#734](#734)) ([e53f23e](e53f23e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
mrmans0n
added a commit
to mrmans0n/codex-acp
that referenced
this pull request
Nov 8, 2026
Upstream v2.6.0 (agentclientprotocol#395) destructures the session config of a fork to carry the permission profile metadata, and adds sessionTitle and permission profile fields to SessionMetadata and to the session lifecycle v2 test client options. The fork point resolution, the forkPoint metadata field and the test option capabilitiesMeta are kept next to upstream's new lines; every added and removed line of the patch is unchanged. Upstream's resolveForkTurnId, which the patch replaces with resolveForkPoint, is unchanged in v2.6.0. Adapted from fc9a61e.
mrmans0n
added a commit
to mrmans0n/codex-acp
that referenced
this pull request
Nov 8, 2026
Upstream v2.6.0 (agentclientprotocol#395) turns the third argument of the session-config-options test helper createSession into an options object with clientCapabilities, permission profiles and approval fields. The patch's neutral test passed the client capabilities positionally, so it no longer type-checked and created a session without the opt-in. It now passes them as options.clientCapabilities. The production code is unchanged: agentclientprotocol#395 does not touch the model or reasoning effort selectors or their recommendations. The neutral test fails with the recommendation record removed. Adapted from 9181cce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #519.
permissionProfile/listturn/startwithout combining them with legacy sandbox policiesBuilt-in and disallowed profiles are omitted from the additional profile entries.
Related to #310.
PR #357 maps the existing fixed ACP modes to configured profiles. This change instead discovers allowed custom profiles dynamically and exposes them as selectable ACP modes.
Testing
npm run typechecknpm test— 404 passed, 28 skippednpm run build