You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fbb15ad
Browse filesBrowse the repository at this point in the historyBrowse files
feat: report the MCP servers that the Codex config replaces (#587)
## Summary
When the Codex config already defines the name of a requested MCP
server, the adapter
skips that server and Codex runs its own entry. The client was not told,
and the startup
wait still counted the skipped name:
- A disabled Codex entry never reports a startup, so `session/new`
waited for the whole
`mcpStartupAwaitTimeoutMs`, and the startup report of the session was
lost.
- An enabled Codex entry reported its startup under the requested name.
Changes:
- **fix:** the startup wait leaves the skipped servers out.
- **feat:** the startup report shows each skipped server as a failed
`mcp__<server>__startup` tool call, like the other startup reports.
## Open question
The report is on for every client. If you prefer, it could be opt-in
through
`clientCapabilities._meta.mcp_startup_skipped`, like `terminal_output`.
The fix would stay
unconditional.
## Tests
- `mcp-config-merge.test.ts` (real Codex): a server that a disabled
config entry replaces,
plus a broken one. Before the fix, the test times out.
- `CodexAcpClient.test.ts`, and the tool call contract snapshots.
- `npm run typecheck`, `npm run build`, `npm test` pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>
Copy file name to clipboardExpand all lines: src/__tests__/tool-calls/data/tool-calls-air.json
+18Lines changed: 18 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -349,5 +349,23 @@
349
349
}
350
350
]
351
351
}
352
+
],
353
+
"mcpSkipped": [
354
+
{
355
+
"sessionUpdate": "tool_call",
356
+
"toolCallId": "mcp_startup.docs",
357
+
"kind": "other",
358
+
"title": "mcp__docs__startup",
359
+
"status": "failed",
360
+
"content": [
361
+
{
362
+
"type": "content",
363
+
"content": {
364
+
"type": "text",
365
+
"text": "[codex-acp] MCP server `docs` was not started, because the Codex config already defines an MCP server with this name. Codex uses its own entry, or no server if that entry is disabled."
Copy file name to clipboardExpand all lines: src/__tests__/tool-calls/data/tool-calls-zed.json
+18Lines changed: 18 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -360,5 +360,23 @@
360
360
}
361
361
]
362
362
}
363
+
],
364
+
"mcpSkipped": [
365
+
{
366
+
"sessionUpdate": "tool_call",
367
+
"toolCallId": "mcp_startup.docs",
368
+
"kind": "other",
369
+
"title": "mcp__docs__startup",
370
+
"status": "failed",
371
+
"content": [
372
+
{
373
+
"type": "content",
374
+
"content": {
375
+
"type": "text",
376
+
"text": "[codex-acp] MCP server `docs` was not started, because the Codex config already defines an MCP server with this name. Codex uses its own entry, or no server if that entry is disabled."
0 commit comments