Repository navigation
Commit 7d7e95a
authored
fix: report verified standard subagent directories (#722)
## Summary
Continues the original SDK 2.2 audit at specification baseline
`d5e9949c3e6a9cd072adebaa44e6f63289590c17`. No later specification
features are added.
- Extend the existing child configuration/readback owner to publish
verified absolute child `cwd` values as standard `subagent_update`
frames on the immediate parent.
- Do not reset directory fields on announcements or replay. `null`
explicitly means inheritance, not unknown placement. Keep retained
overrides until verified current data replaces them, rather than
temporarily replacing a worktree path with the parent's directory.
- Reuse native child-ID, parent-ID, loaded-state, attachment, and
pending-read checks. Current native settings outrank older readback.
Optional readback does not block child output.
- Omit `additionalDirectories`: Codex does not expose an authoritative
child ACP additional-directory list. Do not infer it from provider IDs,
parent roots, or writable sandbox paths, and do not report `[]` or
`null` as a substitute for unknown data.
- Keep AIR's legacy subagent-event contract unchanged.
## Validation
- `npm run typecheck`: passed
- `npm run build`: passed
- `npm test`: 2,379 passed, 39 skipped
- `npm run test:integration`: all 19 passed; the real-Codex child matrix
verifies directory publication before and after reattachment on both
protocol versions
- `git diff --check`: passed
Dual-version wire coverage includes worktree placement, nested parent
routing, replay without inheritance resets, unavailable current
placement, invalid paths, superseded reads, unload/close, and
foreign/mismatched child readback. Existing lifecycle goldens include
the verified directory updates; these goldens consistently end with a
newline.
Includes the same Linux-aware background-process test probe as
#720/#721: Linux zombie/dead PIDs are exited even while they remain
unreaped. A live process at the close-response boundary still fails the
assertion; no post-close wait is added.
The real-Codex integration matrix directly verifies directory behavior.
Opt-in E2E tests were not run. This PR is independently based on main
and does not include #720 or #721. No review Markdown file is included.1 parent 9c33f86 commit 7d7e95a
24 files changed
Lines changed: 163 additions & 31 deletions
File tree
- docs
- src
- __tests__
- CodexACPAgent
- data
- integration
- subagents
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
26 | 34 | | |
27 | 35 | | |
28 | 36 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
686 | 686 | | |
687 | 687 | | |
688 | 688 | | |
689 | | - | |
| 689 | + | |
690 | 690 | | |
691 | 691 | | |
692 | 692 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
22 | 30 | | |
23 | 31 | | |
| |||
48 | 56 | | |
49 | 57 | | |
50 | 58 | | |
51 | | - | |
| 59 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
113 | 121 | | |
114 | | - | |
| 122 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
0 commit comments