Repository navigation
Add support for appending or overriding the system prompt - #91
Merged
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @WhiskeyJack96 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
WhiskeyJack96
commented
Oct 11, 2025
|
|
||
| let systemPrompt: Options["systemPrompt"] = { type: "preset", preset: "claude_code" } | ||
| if (params._meta?.systemPrompt){ | ||
| if (typeof params._meta.systemPrompt === "string") { |
Contributor
Author
There was a problem hiding this comment.
Typescript isnt my strong suit, so if theres a more idiomatic way to handle the union disambiguation I'm happy to give it a go!
Member
|
@WhiskeyJack96 this looks great! I made the checks slightly stricter to be safe, but otherwise it makes sense to me! |
2 tasks done
AObuchow
pushed a commit
to AObuchow/claude-code-acp
that referenced
this pull request
Jan 12, 2026
…tprotocol#91) resolves agentclientprotocol#90 Tested both the `append` and `override` flows by sending: ```javascript const resp = await this.connection.newSession({ cwd: basePath, _meta: { systemPrompt: "you are an obsidian assistant agent, you should be helpful to the user when working with their notes" }, mcpServers: [] }); ``` ```javascript const resp = await this.connection.newSession({ cwd: basePath, _meta: { systemPrompt: { append: "always speak in spanish" } }, mcpServers: [] }); ``` and confirmed that in both cases those prompts are what gets sent to the agent! --------- Co-authored-by: Ben Brandt <[email protected]>
KUKUShuang
pushed a commit
to KUKUShuang/claude-code-acp
that referenced
this pull request
Feb 11, 2026
…ow (agentclientprotocol#91) the agent to use the sandbox
Vercantez
added a commit
to Vercantez/acpx
that referenced
this pull request
Apr 7, 2026
…P _meta Adds global flags --system-prompt <text> and --append-system-prompt <text> that forward through ACP session/new _meta.systemPrompt, using the shape landed in agentclientprotocol/claude-agent-acp#91: _meta.systemPrompt = "..." # replace _meta.systemPrompt = { append: "..." } # append The value is persisted in session_options.system_prompt so acpx claude sessions ensure / reuse flows keep the override, and rides alongside the existing claudeCode options in _meta. Codex and other agents ignore the field. Mutual exclusion between the two flags is enforced at resolve time.
6 of 7 tasks
steipete
pushed a commit
to Vercantez/acpx
that referenced
this pull request
Apr 25, 2026
…P _meta Adds global flags --system-prompt <text> and --append-system-prompt <text> that forward through ACP session/new _meta.systemPrompt, using the shape landed in agentclientprotocol/claude-agent-acp#91: _meta.systemPrompt = "..." # replace _meta.systemPrompt = { append: "..." } # append The value is persisted in session_options.system_prompt so acpx claude sessions ensure / reuse flows keep the override, and rides alongside the existing claudeCode options in _meta. Codex and other agents ignore the field. Mutual exclusion between the two flags is enforced at resolve time.
steipete
pushed a commit
to Vercantez/acpx
that referenced
this pull request
Apr 25, 2026
…P _meta Adds global flags --system-prompt <text> and --append-system-prompt <text> that forward through ACP session/new _meta.systemPrompt, using the shape landed in agentclientprotocol/claude-agent-acp#91: _meta.systemPrompt = "..." # replace _meta.systemPrompt = { append: "..." } # append The value is persisted in session_options.system_prompt so acpx claude sessions ensure / reuse flows keep the override, and rides alongside the existing claudeCode options in _meta. Codex and other agents ignore the field. Mutual exclusion between the two flags is enforced at resolve time.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #90
Tested both the
appendandoverrideflows by sending:and confirmed that in both cases those prompts are what gets sent to the agent!