Repository navigation
fix: refine RFD child models after a load, and retry a failed model update - #1434
Merged
nikita-ashihmin merged 1 commit intoOct 26, 2026
Conversation
…pdate - RFD: a load replay maps no model to the session's model list, which the CLI start brings later. The replay now still gets the session's models, so the current states after the load response map each child's model to the root entry, as before agentclientprotocol#1433. - `reportModel` skips a model only when the client got it. A publication that failed does not block the next report. - A failed load replay also forgets its replayed AIR child models. - The buffer of a child that is not announced collapses only the model reports of `reportModel`. Any other configuration update waits as it is.
benbrandt
pushed a commit
that referenced
this pull request
Oct 26, 2026
🤖 I have created a release *beep* *boop* --- ## [0.96.0](v0.95.0...v0.96.0) (2026-10-26) ### Features * report SendMessage delegations as linked session messages ([#1424](#1424)) ([739dde3](739dde3)) * report the model of each native subagent ([#1432](#1432)) ([c319e5e](c319e5e)) ### Bug Fixes * do not hold an AIR load replay until the CLI starts ([#1433](#1433)) ([eb9d63e](eb9d63e)) * refine RFD child models after a load, and retry a failed model update ([#1434](#1434)) ([9a8bf71](9a8bf71)) * send subagents' current state after a load response ([#1423](#1423)) ([17a967b](17a967b)) * update to Claude Code 2.1.310 ([#1435](#1435)) ([2f3c6bb](2f3c6bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1433, which was merged before these review fixes landed.
session/load(session not live in this process), fix: do not hold an AIR load replay until the CLI starts #1433 also gaveRfdSubagentReplayno model list, so after the load responsecurrentStatescould not map a child's model to the root session'smodelentry. RFD children kept the raw model ID. The replay now reads the session's models when needed; only the in-replay mapping is off while the load replays.reportModelskipped a model that matched the stored options, which are written before the publish. A failed publish then blocked every later report of the same model. It now compares with the last model the client actually received.reportModel; other config updates stay as they are.Tests
replayRfdgained aloadoption that replays like a real load; "sends the model of each child's responses, and after the load response only a changed entry" uses it (fails without the fix).npm run build,npm run check,npm run test:run: 3323 passed, 30 skipped.Related