Repository navigation
Commit ead03b4
committed
fix(ci): stop the Windows leg from truncating and mismeasuring its own shards
Run 32340498394 dispatched the Windows leg at the release head and produced
three results that were not defects in this repository:
1. shard 1/4 was CANCELLED at 15m12s while still executing tests. That is
neither a pass nor a fail, and it silently removed the composed-acceptance
cases from the evidence. The other shards finished at 14-15 minutes, so 15
was inside the noise band rather than above it. Raised to 25, which still
kills a wedged shard and now also covers the second attempt the crash retry
is allowed to make.
2. `Responses previous_response_id state > orphan cleanup obeys scan and
cleanup caps` ran 100.6s against a 90s budget on shard 4/4 while doing
exactly the work it claims: 521 individually fsync'd durable writes. The
number was sized from a ~34s windows-latest measurement and was measuring
runner contention, not a hang. BULK_DURABLE_IO_BUDGET_MS now carries a
Windows-only 180s ceiling, the same shape as the watchdogMs floor.
3. `Claude Code shell-hook reconciliation > does not treat a non-executable
claude file as an installed CLI` writes mode 0o644 and expects
claudeCodeCliInstalled() to be false. Windows has no execute-permission
bit, so accessSync(path, X_OK) succeeds for any readable file and the
fixture cannot express its own precondition. It now skips on win32, as
several neighbouring symlink cases already do.
Refs lidge-jun#2152.1 parent 5238e11 commit ead03b4
4 files changed
Lines changed: 43 additions & 9 deletions
File tree
- .github/workflows
- tests
- helpers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
557 | 566 | | |
558 | 567 | | |
559 | 568 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
88 | 95 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
93 | 101 | | |
94 | 102 | | |
95 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
48 | 63 | | |
49 | 64 | | |
50 | 65 | | |
| |||
0 commit comments