Repository navigation
benchmarking: put the glutton data dir on the rootfs - #3647
Merged
Max Smythe (maxsmythe) merged 1 commit intoNov 5, 2026
Merged
Conversation
The glutton template stored WriteDisk files under /tmp, which is a tmpfs on both sandbox classes, so they counted as memory and no benchmark wrote to the rootfs upper layer. Use /var/lib/glutton with no volume mounted instead, so agentsession's files land in the rootfs upper layer and in its snapshot. On gVisor, agentsession now writes to the rootfs for the first time, so its numbers will change. Signed-off-by: Chenyi Wang <[email protected]>
Collaborator
|
Merging as benchmark-only PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gluttontemplate storedWriteDiskfiles under/tmp, which is atmpfson both sandbox classes (#3533), so they counted as memory and no benchmark wrote to the rootfs upper layer. Use/var/lib/gluttonwith no volume mounted instead, soagentsession's files land in the rootfs upper layer and in its snapshot.On gVisor,
agentsessionnow writes to the rootfs for the first time, so its numbers will change. On microVM, its files go back to the host-backed rootfs upper layer, as before #3533.AI use: AI-assisted, I reviewed and tested it.