Skip to content

e2e tests: Extend the existing tests to cover tag actor. - #3511

Merged
Zoe Zhao (zoez7) merged 2 commits into
agent-substrate:mainfrom
nybidari:e2e-tag-clone-resume
Nov 2, 2026
Merged

Zoe Zhao (zoez7) merged 2 commits into
agent-substrate:mainfrom
nybidari:e2e-tag-clone-resume

Conversation

@nybidari

@nybidari nybidari commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

TestActorSnapshotLifecycle created a Tag and resumed a clone from it, but did not verify in e2e that the tag's snapshot copy survives deleting the source actor or that the clone's own snapshot survives DeleteTag.
Delete sourceName before creating the clone from tagRef, and after the clone runs, suspend it, wait for background detach, delete tagRef, and resume the clone to verify its counters continue at (3, 3).

AI use:
AI-assisted, I reviewed and tested it

  • Tests pass
  • Docs updated

cloneSnap := snapshotAtLatestGeneration(cloneSuspended.GetActor().GetStatus())
if got := cloneSnap.GetDurableSnapshot().GetState(); got != ateapi.SnapshotStorageState_SNAPSHOT_STORAGE_STATE_COMPLETED {
t.Fatalf("cloned Actor snapshot DurableSnapshot.State = %v, want COMPLETED", got)
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit 🟢 – At creation, cloned borrows tagSnapshotURI(tagToUpdate). Also check that cloneSnap's URI is non-empty and differs from tagSnapshotURI(tagToUpdate) (matching line 246), so we verify the suspend replaced the borrowed tag snapshot with the clone's own before DeleteTag runs.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread internal/e2e/suites/demo/demo_test.go Outdated
waitForActorDetached(ctx, t, clients, cloneName, cloneSnap.GetUuid())
})

if _, err := clients.SubstrateAPI.DeleteTag(ctx, &ateapi.DeleteTagRequest{Tag: tagRef}); err != nil {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 nit 🟢 – Call DeleteTag before t.Run("BackgroundDetach", ...). cloneSuspended has already written the clone's own snapshot, so DeleteTag can run while atelet's 30s detach timer is ticking instead of after waitForActorDetached returns.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread internal/e2e/suites/demo/demo_test.go Outdated
// still resumes after DeleteTag collects the tag's snapshot.
cloneSuspended, err := clients.SubstrateAPI.SuspendActor(ctx, &ateapi.SuspendActorRequest{
Actor: &ateapi.ObjectRef{Atespace: demoAtespace, Name: cloneName},
Options: &ateapi.SuspendOptions{Mode: ateapi.DurabilityMode_DURABILITY_MODE_SYNCHRONOUS},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 should-fix 🟡 – Hardcoding DURABILITY_MODE_SYNCHRONOUS here means both the sync and async subtests only cover DeleteTag when cloneName's snapshot is already uploaded (COMPLETED). Could we also cover the async suspend case (DURABILITY_MODE_ASYNCHRONOUS, where cloneName's snapshot is still PENDING and pruneSnapshots retains the borrowed tag snapshot alongside the pending local snapshot), for example by using tc.mode here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- Use tc.mode and tc.wantStorage when suspending cloneName so the async subtest
also covers DeleteTag while the clone's snapshot is PENDING.
- Check that cloneSnap's URI is non-empty and differs from tagSnapshotURI(tagToUpdate).
- Call DeleteTag before t.Run("BackgroundDetach", ...).

Signed-off-by: Nayana Bidari <[email protected]>
@zoez7
Zoe Zhao (zoez7) added this pull request to the merge queue Nov 2, 2026
Merged via the queue into agent-substrate:main with commit 57fab75 Nov 2, 2026
8 of 9 checks passed
Dmitry Berkovich (dberkov) pushed a commit that referenced this pull request Nov 3, 2026
Bring `release-1.0` up to `main` at
5a5b192 with the 19 changes merged
since the previous batch in #3536. The final tree matches that commit
exactly.

**Please use Rebase and merge to preserve the individual commits and
author attribution.** All 19 applied cleanly in upstream order. Original
authors, author dates, co-author and sign-off trailers, and `-x` source
references are retained.

Upgrade notes:

- #3533: old gVisor MEMORY snapshots, including goldens, no longer
restore. Recreate them after upgrading. MicroVM MEMORY snapshots still
resume with their old mounts until recreated. `/tmp` is now always
tmpfs; ROOTFS snapshots no longer preserve its contents, and
image-provided files there are hidden. MicroVM `/tmp` counts against
actor memory and is capped at half the guest's memory. gVisor `/dev/shm`
is now a 64 MiB tmpfs. Mount a `durableDir` at either path when
persistence or more space is needed. `/run` now comes from the image
rootfs.
- #3447: remove `--actor-jwt-jwks-file` from custom credential-exchange
sidecar configs. Set `--actor-jwt-issuer-ca-file` only when the issuer
uses a private CA other than the service DNS CA.

- #3450: do not reuse a deleted atespace name. See the updated atespace
name-reuse guidance.

Includes #3505, which overlaps the open backport in #3547. GKE
provisioning and teardown now live in
[substrate-gke](https://github.com/ai-on-gke/substrate-gke) rather than
this repository.

<details>
<summary>Included PRs, in cherry-pick order</summary>

1. #3500: demos/{sandbox,jupyter,multi-template}: fix tutorial
prerequisites, walkthroughs, and counter volume
2. #3498: demos/counter: inline gVisor walkthrough and fix setup
commands
3. #3511: e2e tests: Extend the existing tests to cover tag actor.
4. #2775: Generate API reference documentation and publish it on
Substrate website
5. #3119: Document how people, pods and CI jobs should authenticate to
ate-api
6. #3505: tools: remove setup-gcp and hack/teardown.sh
7. #3147: e2e: resume fidelity after SandboxConfig version edits
8. #3370: ate-setup: reconcile ate-api-server ConfigMaps and roll out on
config changes
9. #1607: hack: reject breaking proto changes across each proto package
10. #3415: docs: update and add security diagrams
11. #3485: Resuming a microVM actor on the same node no longer reads its
rootfs upper back from disk
12. #3447: Verify actor JWTs in the credential exchange through OIDC
discovery
13. #3533: ocispec: mount tmpfs at /dev/shm, and /tmp on both runtimes
14. #3450: docs: Document that atespace names must not be reused
15. #3410: Document using more than one egress credential provider
16. #3486: atelet: register the device plugin on a new socket each time
17. #3553: ate-setup: wait for the demo namespace in delete demo
18. #3560: Fix multiple issues in claude-code-multiplex demo
19. #3517: docs: remove inaccurate early-stage architecture
documentation

</details>

Validation: every intermediate tree matches its upstream source commit,
all 19 authorship records and original attribution trailers are
preserved, and `git diff --check` passes. The original 18 backport
commits are unchanged.

AI use: AI-assisted cherry-picking, attribution checks, and review.

- [ ] Tests pass
- [x] Docs updated

---------

Signed-off-by: Mofi Rahman <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Nayana Bidari <[email protected]>
Signed-off-by: Julian Gutierrez Oschmann <[email protected]>
Signed-off-by: Max Thompson <[email protected]>
Signed-off-by: Steven Shriver <[email protected]>
Signed-off-by: Grant McCloskey <[email protected]>
Signed-off-by: Shrutiya <[email protected]>
Signed-off-by: Haiyan Meng <[email protected]>
Signed-off-by: Greg Castle <[email protected]>
Signed-off-by: Benjamin Elder <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Shruti Nair <[email protected]>
Signed-off-by: Haven Xia <[email protected]>
Co-authored-by: Mofi Rahman <[email protected]>
Co-authored-by: nybidari <[email protected]>
Co-authored-by: Julian Gutierrez Oschmann <[email protected]>
Co-authored-by: Max Thompson <[email protected]>
Co-authored-by: Grant McCloskey <[email protected]>
Co-authored-by: Steven Shriver <[email protected]>
Co-authored-by: shrutiyam-glitch <[email protected]>
Co-authored-by: haiyanmeng <[email protected]>
Co-authored-by: Greg Castle <[email protected]>
Co-authored-by: Benjamin Elder <[email protected]>
Co-authored-by: Anish Ramasekar <[email protected]>
Co-authored-by: Shruti Nair <[email protected]>
Co-authored-by: Haven Xia <[email protected]>
Co-authored-by: Adam Wathieu <[email protected]>
Dmitry Berkovich (dberkov) pushed a commit that referenced this pull request Nov 3, 2026
`TestActorSnapshotLifecycle` created a `Tag` and resumed a clone from
it, but did not verify in e2e that the tag's snapshot copy survives
deleting the source actor or that the clone's own snapshot survives
`DeleteTag`.
Delete `sourceName` before creating the clone from `tagRef`, and after
the clone runs, suspend it, wait for background detach, delete `tagRef`,
and resume the clone to verify its counters continue at `(3, 3)`.

AI use:
AI-assisted, I reviewed and tested it

- [x] Tests pass
- [ ] Docs updated

---------

Signed-off-by: Nayana Bidari <[email protected]>
(cherry picked from commit 57fab75)
Signed-off-by: Eitan Yarmush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants