Repository navigation
demos/counter: remove sandbox IP greeting from counter response - #3510
Merged
Dmitry Berkovich (dberkov) merged 2 commits intoOct 31, 2026
Merged
Dmitry Berkovich (dberkov) merged 2 commits into
Dmitry Berkovich (dberkov) merged 2 commits into
Conversation
Zoe Zhao (zoez7)
marked this pull request as ready for review
October 30, 2026 23:31
Zoe Zhao (zoez7)
requested review from
Haven Xia (HavenXia) and
Dmitry Berkovich (dberkov)
October 30, 2026 23:31
| // Command counter is a simple server that will be used as a worker pod. It listens on ports 80 | ||
| // and returns a greeting with the IP of the pod where it is running. | ||
| // Command counter is a simple HTTP server that listens on port 80 and increments | ||
| // counters in memory, on a durable volume, and on the root filesystem. |
Collaborator
There was a problem hiding this comment.
nit: the counter demo support --extra-port and --tcp-port
getCurrentIP returns the sandbox's fixed link-local veth address (169.254.17.2) rather than the worker pod IP. Remove it from the counter response and update the demo docs to check the worker pod assignment with kubectl ate get actor. Signed-off-by: Zoe Zhao <[email protected]>
Signed-off-by: Zoe Zhao <[email protected]>
Zoe Zhao (zoez7)
force-pushed
the
remove-counter-hello-from
branch
from
October 30, 2026 23:47
df8cd23 to
f044c39
Compare
Dmitry Berkovich (dberkov)
approved these changes
Oct 31, 2026
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
<!-- The PR title becomes the release note. Write it for users. --> Follow-up to #3498 (comment). Remove `hello from: %s` and `getCurrentIP()` from `demos/counter/counter.go`. Why? `counter.go` included `hello from: <ip>` in its response from early dyas of Substrate to show that an actor resumed on a different worker Pod IP. However, now every actor sandbox uses the fixed veth address `169.254.17.2` (`ActorVethIP` in `internal/ateworker/actornet/net.go`), so `getCurrentIP()` always returns `169.254.17.2` regardless of which worker Pod hosts the actor. Also updated documentations to remove mentioning of "the different worker Pod IP replied by counter indicates it was resumed on another pod". <!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author trailers. --> AI use: AI-assisted to update the counter demo, docs, and tests; I reviewed the diff. <!-- Breaking change? Describe what users must do on upgrade and ask for the `breaking-change` label. --> - [x] Tests pass - [x] Docs updated --------- Signed-off-by: Zoe Zhao <[email protected]> (cherry picked from commit 659832f) Signed-off-by: Eitan Yarmush <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3498 (comment). Remove
hello from: %sandgetCurrentIP()fromdemos/counter/counter.go.Why?
counter.goincludedhello from: <ip>in its response from early dyas of Substrate to show that an actor resumed on a different worker Pod IP. However, now every actor sandbox uses the fixed veth address169.254.17.2(ActorVethIPininternal/ateworker/actornet/net.go), sogetCurrentIP()always returns169.254.17.2regardless of which worker Pod hosts the actor.Also updated documentations to remove mentioning of "the different worker Pod IP replied by counter indicates it was resumed on another pod".
AI use: AI-assisted to update the counter demo, docs, and tests; I reviewed the diff.