Repository navigation
docs: document sandbox class differences and fix stale passages - #3468
Merged
Dmitry Berkovich (dberkov) merged 2 commits intoOct 30, 2026
Merged
Dmitry Berkovich (dberkov) merged 2 commits into
Dmitry Berkovich (dberkov) merged 2 commits into
Conversation
nybidari
force-pushed
the
docs-sandbox-classes
branch
4 times, most recently
from
October 30, 2026 00:57
9cc5abd to
90ef049
Compare
nybidari
requested review from
Benjamin Elder (BenTheElder),
Dmitry Berkovich (dberkov) and
Fabricio Voznika (fvoznika)
October 30, 2026 01:01
nybidari
force-pushed
the
docs-sandbox-classes
branch
2 times, most recently
from
October 30, 2026 01:34
8fbbca7 to
930bc6f
Compare
Comment on lines
+498
to
+499
| A snapshot without `sandboxRuntime` or with `SNAPSHOT_FIDELITY_ROOTFS` or | ||
| `SNAPSHOT_FIDELITY_VOLUMES` imposes no runtime placement constraint. Because a | ||
| `SNAPSHOT_FIDELITY_VOLUMES` imposes no runtime placement constraint. On gVisor, |
Collaborator
There was a problem hiding this comment.
🤖 should-fix 🟡 – "No runtime placement constraint" is only true of the runtime version. The scheduler still pins every fidelity to the snapshot's sandbox class (cmd/ateapi/internal/scheduling/scheduling.go:35-41), which is what sandbox-classes.md says above. As written, this sentence reads as contradicting it.
Suggest: "imposes no runtime-version placement constraint, though it still runs on a worker of the snapshot's sandbox class."
Collaborator
Author
There was a problem hiding this comment.
Done, also rebased.
nybidari
force-pushed
the
docs-sandbox-classes
branch
2 times, most recently
from
October 30, 2026 02:01
105bd15 to
bbca727
Compare
Add docs/reference/sandbox-classes.md comparing the gvisor and microvm sandbox classes across CPU sizing, memory limits, per-container limits, NET_RAW capabilities, system mounts, and VOLUMES/ROOTFS snapshots. Document the gVisor fscheckpoint compatibility requirement for cross-version filesystem restores, the runsc CPU count floor of 2, and NET_RAW stripping in the API guide and version skew policy. Update stale references across architecture, glossary, overview, quickstart, and guides. Signed-off-by: Nayana Bidari <[email protected]>
Update the API guide about imposing no runtime placement constraint. Signed-off-by: Nayana Bidari <[email protected]>
nybidari
force-pushed
the
docs-sandbox-classes
branch
from
October 30, 2026 02:03
bbca727 to
dd4d113
Compare
Dmitry Berkovich (dberkov)
approved these changes
Oct 30, 2026
16 of 23 tasks
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
Part of #3226 Add docs/reference/sandbox-classes.md comparing the gvisor and microvm sandbox classes across CPU sizing, memory limits, per-container limits, NET_RAW capabilities, system mounts, VOLUMES/ROOTFS snapshots and gVisor fscheckpoint compatibility requirement for cross-version filesystem restores. Update stale references across architecture, glossary, quickstart, and guides. AI use: AI-assisted, I reviewed and tested it. - [ ] Tests pass - [x] Docs updated --------- Signed-off-by: Nayana Bidari <[email protected]> (cherry picked from commit 46b6ea9) Signed-off-by: Eitan Yarmush <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3226
Add docs/reference/sandbox-classes.md comparing the gvisor and microvm sandbox classes across CPU sizing, memory limits, per-container limits, NET_RAW capabilities, system mounts, VOLUMES/ROOTFS snapshots and gVisor fscheckpoint compatibility requirement for cross-version filesystem restores. Update stale references across architecture, glossary, quickstart, and guides.
AI use:
AI-assisted, I reviewed and tested it.