Repository navigation
benchmarking: add --test-name to run selected orchestrator tests - #3464
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 31, 2026
Merged
Conversation
haiyanmeng
marked this pull request as draft
October 29, 2026 21:41
haiyanmeng
force-pushed
the
run-specific-tests
branch
from
October 29, 2026 21:44
87c661f to
475a269
Compare
The orchestrator ran every entry in the --tests file, so running one test meant copying it into a new file first. --test-name NAME runs only the named entries and can be repeated. The orchestrator now selects and validates the entries before it waits for Docker and clones the repo, so a mistyped name fails right away. A relative --tests path now resolves against the working directory instead of the clone. Signed-off-by: Haiyan Meng <[email protected]>
haiyanmeng
force-pushed
the
run-specific-tests
branch
from
October 29, 2026 21:53
475a269 to
dba942f
Compare
haiyanmeng
requested review from
Julian Gutierrez Oschmann (juli4n) and
Max Smythe (maxsmythe)
October 29, 2026 21:55
haiyanmeng
added
area/benchmarking
kind/feature
haiyanmeng
marked this pull request as ready for review
October 29, 2026 21:56
Collaborator
|
This is a benchmarking-only change, merging. |
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
The orchestrator ran every entry in the `--tests` file, so running one test meant copying it into a new file first. `--test-name NAME` runs only the named entries and can be repeated. The orchestrator now selects and validates the entries before it waits for Docker and clones the repo, so a mistyped name fails right away. A relative `--tests` path now resolves against the working directory instead of the clone. <!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author trailers. --> AI use: AI-assisted, I reviewed and tested it <!-- Breaking change? Describe what users must do on upgrade and ask for the `breaking-change` label. --> - [x] Tests pass - [x] Docs updated Signed-off-by: Haiyan Meng <[email protected]> (cherry picked from commit 0ddbf78) Signed-off-by: Eitan Yarmush <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The orchestrator ran every entry in the
--testsfile, so running one test meant copying it into a new file first.--test-name NAMEruns only the named entries and can be repeated.The orchestrator now selects and validates the entries before it waits for Docker and clones the repo, so a mistyped name fails right away. A relative
--testspath now resolves against the working directory instead of the clone.AI use: AI-assisted, I reviewed and tested it