Repository navigation
docs: note that pools selected by ActorTemplate.worker_selector must share a CPU architecture - #3458
Merged
Conversation
Shrutiya Mohan (shrutiyam-glitch)
changed the title
Shrutiya Mohan (shrutiyam-glitch)
marked this pull request as ready for review
October 29, 2026 20:41
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
fix-doc
branch
3 times, most recently
from
October 29, 2026 23:35
6c69703 to
3d540ce
Compare
Zoe Zhao (zoez7)
previously approved these changes
Oct 30, 2026
Signed-off-by: Shrutiya <[email protected]>
Shrutiya Mohan (shrutiyam-glitch)
force-pushed
the
fix-doc
branch
from
October 30, 2026 18:09
2f95284 to
e1e856a
Compare
Zoe Zhao (zoez7)
approved these changes
Oct 30, 2026
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
…share a CPU architecture (#3458) Part of #3230 A `SNAPSHOT_FIDELITY_ROOTFS` restore reuses the container's rootfs upper layer, which can contain architecture-specific binaries written on the worker where the snapshot was captured. Until the scheduler filters by CPU architecture on fallback, every `WorkerPool` selected by an `ActorTemplate` must run on the same CPU architecture. Previously, this requirement was only mentioned under `Snapshot Storage Layout` (`sandboxRuntime`) in `docs/reference/api-guide.md`. Surface it where operators and users configure pools and templates: - `README.md`: add `Known limitations` under `Status and compatibility`. - `docs/reference/api-guide.md`: note how to pin and label `WorkerPool`s in mixed-architecture clusters under `WorkerPoolPodTemplate`, and note the single-architecture requirement on `ActorTemplate.workerSelector`. - `api/ateapi/v1/ateapi.proto` (`ateapi.pb.go`): document the requirement on `ActorTemplate.worker_selector`. Used an AI assistant to draft the documentation wording and reviewed it locally. - [x] Tests pass - [x] Docs updated Signed-off-by: Shrutiya <[email protected]> (cherry picked from commit af42c9d) Signed-off-by: Eitan Yarmush <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3230
A
SNAPSHOT_FIDELITY_ROOTFSrestore reuses the container's rootfs upper layer, which can contain architecture-specific binaries written on the worker where the snapshot was captured. Until the scheduler filters by CPU architecture on fallback, everyWorkerPoolselected by anActorTemplatemust run on the same CPU architecture.Previously, this requirement was only mentioned under
Snapshot Storage Layout(sandboxRuntime) indocs/reference/api-guide.md. Surface it where operators and users configure pools and templates:README.md: addKnown limitationsunderStatus and compatibility.docs/reference/api-guide.md: note how to pin and labelWorkerPools in mixed-architecture clusters underWorkerPoolPodTemplate, and note the single-architecture requirement onActorTemplate.workerSelector.api/ateapi/v1/ateapi.proto(ateapi.pb.go): document the requirement onActorTemplate.worker_selector.Used an AI assistant to draft the documentation wording and reviewed it locally.