Repository navigation
[bug fix] Export atenet-egress traces and metrics with service.name=atenet-egress - #3417
Merged
Eitan Yarmush (EItanya) merged 1 commit intoOct 31, 2026
Conversation
Bo-Cheng Chu (bochengchu)
force-pushed
the
egress-service-name
branch
from
October 29, 2026 00:16
21c3105 to
4de91dd
Compare
Bo-Cheng Chu (bochengchu)
marked this pull request as ready for review
October 29, 2026 00:20
Bo-Cheng Chu (bochengchu)
requested review from
Jeff Luo (JeffLuoo) and
Bowei Du (bowei)
October 29, 2026 00:21
Collaborator
|
Please rebase |
Bo-Cheng Chu (bochengchu)
force-pushed
the
egress-service-name
branch
3 times, most recently
from
October 29, 2026 20:57
76ec734 to
87db6ff
Compare
Select the OTel service name from s.cfg.Mode in RouterServer.Run so that --mode=egress exports traces and metrics as atenet-egress instead of atenet-router. Also include atenet-egress in otelOverrideDeployments so --otlp-endpoint restarts it alongside the other control plane workloads. Fixes agent-substrate#3308 Signed-off-by: Bo-Cheng Chu <[email protected]>
Bo-Cheng Chu (bochengchu)
force-pushed
the
egress-service-name
branch
from
October 29, 2026 21:02
87db6ff to
d9cd1b5
Compare
Collaborator
Author
|
Bowei Du (@bowei) The OTel name is now set based on |
Bo-Cheng Chu (bochengchu)
requested review from
Jeff Luo (JeffLuoo) and
Bowei Du (bowei)
October 29, 2026 21:10
Bowei Du (bowei)
approved these changes
Oct 29, 2026
Lior Lieberman (LiorLieberman)
changed the title
Tim Hockin (thockin)
approved these changes
Oct 31, 2026
Tim Hockin (thockin)
left a comment
Tim Hockin (thockin)
left a comment
Collaborator
There was a problem hiding this comment.
OK for followup
| // below, because otelgrpc.NewClientHandler captures the global | ||
| // TracerProvider at construction time. Resolved once so the router's SDK | ||
| // sampler and Envoy's RandomSampling percent cannot drift. | ||
| serviceName := "atenet-router" |
Collaborator
There was a problem hiding this comment.
We define this twice - should it just be something like cmd/atenet/internal/metrics.ServiceName ?
Collaborator
There was a problem hiding this comment.
Bo-Cheng Chu (@bochengchu) can you take this follow up?
Eitan Yarmush (EItanya)
approved these changes
Oct 31, 2026
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
…tenet-egress (#3417) `atenet-egress` runs `cmd/atenet router --mode=egress`, which previously initialized OpenTelemetry with the hardcoded service name `"atenet-router"`. - Set OTel `service.name` in `RouterServer.Run` based on `--mode` (`"atenet-egress"` for egress, `"atenet-router"` for ingress) and pass the meter to `extproc.NewRouteDurationHistogram`. - Remove the unused trace span in `handleStatusz`. - Include `atenet-egress` in `ate-setup`'s `otelOverrideDeployments` so `--otlp-endpoint` restarts it too. - Update the metrics registry/docs and E2E metrics test to verify `atenet-egress` telemetry is exported under `atenet-egress` and not `atenet-router`. Fixes #3308 <!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author trailers. --> AI use: <!-- Breaking change? Describe what users must do on upgrade and ask for the `breaking-change` label. --> - [ ] Tests pass - [ ] Docs updated Signed-off-by: Bo-Cheng Chu <[email protected]> (cherry picked from commit 0f7ebfa) Signed-off-by: Eitan Yarmush <[email protected]>
1 of 2 tasks
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atenet-egressrunscmd/atenet router --mode=egress, which previously initialized OpenTelemetry with the hardcoded service name"atenet-router".service.nameinRouterServer.Runbased on--mode("atenet-egress"for egress,"atenet-router"for ingress) and pass the meter toextproc.NewRouteDurationHistogram.handleStatusz.atenet-egressinate-setup'sotelOverrideDeploymentsso--otlp-endpointrestarts it too.atenet-egresstelemetry is exported underatenet-egressand notatenet-router.Fixes #3308
AI use: