tools: remove setup-gcp and hack/teardown.sh by stshrive · Pull Request #3396 · agent-substrate/substrate

Steven Shriver (stshrive) · 2026-10-28T18:27:12Z

The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match.

Covers #3390, except that hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it.

Part of #2304

Aditya Shantanu (aditya-shantanu)

DCO is a required check and fails: the commit author is [email protected] but the sign-off is [email protected]. Also, per AGENTS.md, drop the #3390 / #2304 references from the commit message and keep them in the PR description.

Aditya Shantanu (aditya-shantanu)

Approving now that substrate-gke has --cluster-scoped. The DCO check still needs the sign-off email to match the author email before this can merge.

Haven Xia (HavenXia)

others lgtm

Steven Shriver (stshrive) · 2026-10-29T00:21:57Z

DCO is a required check and fails: the commit author is [email protected] but the sign-off is [email protected]. Also, per AGENTS.md, drop the #3390 / #2304 references from the commit message and keep them in the PR description.

This is now resolved

Grant McCloskey (MushuEE) · 2026-10-29T00:27:51Z

Cleanup these after this change gets in: #2745 #2532 #1999

I think these are mostly covered by changes in https://github.com/ai-on-gke/substrate-gke already.

The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Signed-off-by: Steven Shriver <[email protected]>

Haven Xia (HavenXia) · 2026-10-29T16:03:57Z

need rebase

Haven Xia (HavenXia) · 2026-10-29T22:22:55Z

After this, nothing in core reads CLUSTER_VERSION, NODE_POOL_NAME or NODE_POOL_VERSION. Could you drop them from hack/ate-dev-env.sh.example here? That would also fix #3371.

Tim Hockin (thockin) · 2026-10-30T00:08:28Z

@@ -219,7 +219,7 @@ it alongside the gateway. The install applies:
  (`app: atenet-egress`), on the provider's gRPC port. Every other connection
  to the provider pods is dropped. The NetworkPolicy takes effect only on a
  cluster whose network plugin enforces NetworkPolicy, such as GKE Dataplane


This is going to be annoying, but... I think we should reduce or eliminate almost all xrefs to GCP and GKE specific stuff, especially in contexts like this. It doesn't add any clarity ("NetworkPolicy takes effect only on a cluster whose network plugin enforces NetworkPolicy" is tautologically true and sufficient). Worse, it encourages OTHER ecosystem players to request putting their own name here.

Docs are not advertisements.

💯, but can we do more cleanup like that in subsequent PRs where this PR didn't make it worse?

Benjamin Elder (BenTheElder) · 2026-10-30T06:45:40Z

Steven is OOO for a few days I think?, maybe we should have someone pick this up and rebase it.

Tim Hockin (thockin) · 2026-10-30T15:35:00Z

Edit: I was ignoring the code removal. We should land that.

~~AFAICT this doesn't really have to land in 1.0.0, there's no real code to it, so I am putting it on the back-burner.~~

Tim Hockin (thockin) · 2026-10-30T17:48:47Z

Moved back to M3, but after discussion we should split this two 2 PRs. 1) remove GCP setup code; 2) Fix docs / comments etc. We want (1) for RC2

Grant McCloskey (MushuEE) · 2026-10-30T17:50:20Z

I am taking this over to rebase, presume there is no way to take over from Steven short term.

Grant McCloskey (MushuEE) · 2026-10-30T18:38:35Z

This had conflicts with main (mostly from the Hugo docsite move in #1974), so I rebased it and opened #3505 with your commit and authorship preserved. The PR description there explains how each conflict was resolved. If you'd rather keep it here, you can reset your branch to that commit instead, and I'll close #3505.

@stshrive

Supersedes agent-substrate#3396 by @stshrive, rebased onto current `main`. The commit keeps his authorship and sign-off. The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. Covers agent-substrate#3390, except that hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Part of agent-substrate#2304 ### Rebase notes Conflicts were mostly from the Hugo docsite move (agent-substrate#1974): - `tools/setup-gcp/cloud-sql.md`: deleted, as in the original PR. - `docs/guides/operator-install.md`, `docs/guides/postgres.md`: the original edits, re-applied at the new paths. - `docs/guides/observability.md`: kept main's version, since agent-substrate#1974 already removed the Dashboards section the original PR edited. - `cmd/kubectl-ate/README.md`: kept main's stub that points to `docs/reference/kubectl-ate.md`. That page no longer has the setup-gcp line, so the edit had nowhere to go. --------- Signed-off-by: Steven Shriver <[email protected]> Signed-off-by: Grant McCloskey <[email protected]> Co-authored-by: Steven Shriver <[email protected]>

@stshrive

Supersedes agent-substrate#3396 by @stshrive, rebased onto current `main`. The commit keeps his authorship and sign-off. The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. Covers agent-substrate#3390, except that hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Part of agent-substrate#2304 ### Rebase notes Conflicts were mostly from the Hugo docsite move (agent-substrate#1974): - `tools/setup-gcp/cloud-sql.md`: deleted, as in the original PR. - `docs/guides/operator-install.md`, `docs/guides/postgres.md`: the original edits, re-applied at the new paths. - `docs/guides/observability.md`: kept main's version, since agent-substrate#1974 already removed the Dashboards section the original PR edited. - `cmd/kubectl-ate/README.md`: kept main's stub that points to `docs/reference/kubectl-ate.md`. That page no longer has the setup-gcp line, so the edit had nowhere to go. --------- Signed-off-by: Steven Shriver <[email protected]> Signed-off-by: Grant McCloskey <[email protected]> Co-authored-by: Steven Shriver <[email protected]> (cherry picked from commit b66e16a)

@stshrive

Supersedes #3396 by @stshrive, rebased onto current `main`. The commit keeps his authorship and sign-off. The GKE provisioning and teardown tooling now lives in https://github.com/ai-on-gke/substrate-gke under tools/setup-gcp, so core no longer carries a copy. Docs and comments that pointed at the removed files now point at substrate-gke. go mod tidy drops the GCP client modules only setup-gcp used, and vendor/ and _LICENSES/ are regenerated to match. Covers #3390, except that hack/teardown.sh is removed here as well; substrate-gke's tools/setup-gcp/teardown.sh replaces it. Part of #2304 ### Rebase notes Conflicts were mostly from the Hugo docsite move (#1974): - `tools/setup-gcp/cloud-sql.md`: deleted, as in the original PR. - `docs/guides/operator-install.md`, `docs/guides/postgres.md`: the original edits, re-applied at the new paths. - `docs/guides/observability.md`: kept main's version, since #1974 already removed the Dashboards section the original PR edited. - `cmd/kubectl-ate/README.md`: kept main's stub that points to `docs/reference/kubectl-ate.md`. That page no longer has the setup-gcp line, so the edit had nowhere to go. --------- Signed-off-by: Steven Shriver <[email protected]> Signed-off-by: Grant McCloskey <[email protected]> Co-authored-by: Steven Shriver <[email protected]> (cherry picked from commit b66e16a) Signed-off-by: Eitan Yarmush <[email protected]>

Steven Shriver (stshrive) requested review from Benjamin Elder (BenTheElder), Grant McCloskey (MushuEE), Aditya Shantanu (aditya-shantanu) and Greg Castle (destijl) October 28, 2026 18:27

Steven Shriver (stshrive) mentioned this pull request Oct 28, 2026

manifests: remove the GKE-specific install content #3399

Draft

Aditya Shantanu (aditya-shantanu) suggested changes Oct 28, 2026

View reviewed changes

Comment thread README.md Resolved

Aditya Shantanu (aditya-shantanu) approved these changes Oct 28, 2026

View reviewed changes

Grant McCloskey (MushuEE) approved these changes Oct 28, 2026

View reviewed changes

Steven Shriver (stshrive) force-pushed the dev/remove-setup-gcp branch 4 times, most recently from a2b4efc to de1988a Compare October 28, 2026 22:34

Steven Shriver (stshrive) requested a review from Haven Xia (HavenXia) October 28, 2026 22:35

Haven Xia (HavenXia) reviewed Oct 28, 2026

View reviewed changes

Comment thread AGENTS.md Resolved

Haven Xia (HavenXia) previously approved these changes Oct 28, 2026

View reviewed changes

This was referenced Oct 28, 2026

[EPIC] Make repository Provider Neutral #3161

Open

Complete migration of tools/setup-gcp from agent-substrate/substrate (parity gaps) ai-on-gke/substrate-gke#82

Open

Steven Shriver (stshrive) dismissed Haven Xia (HavenXia)’s stale review via 7a1f314 October 29, 2026 00:15

Grant McCloskey (MushuEE) mentioned this pull request Oct 29, 2026

Stage micro-VM assets to GCS from substrate-gke ai-on-gke/substrate-gke#88

Closed

Steven Shriver (stshrive) force-pushed the dev/remove-setup-gcp branch from 7a1f314 to 4936ec4 Compare October 29, 2026 00:21

Haven Xia (HavenXia) previously approved these changes Oct 29, 2026

View reviewed changes

Steven Shriver (stshrive) mentioned this pull request Oct 29, 2026

ate-setup: add a render subcommand for manifest generation #3411

Open

Steven Shriver (stshrive) dismissed Haven Xia (HavenXia)’s stale review via d10d543 October 29, 2026 01:49

Steven Shriver (stshrive) force-pushed the dev/remove-setup-gcp branch from 4936ec4 to d10d543 Compare October 29, 2026 01:49

Tim Hockin (thockin) added this to the M3 milestone Oct 29, 2026

Tim Hockin (thockin) self-assigned this Oct 29, 2026

Dmitry Berkovich (dberkov) added the milestone-ack label Oct 29, 2026

Tim Hockin (thockin) assigned Benjamin Elder (BenTheElder) Oct 29, 2026

Tim Hockin (thockin) reviewed Oct 30, 2026

View reviewed changes

Haven Xia (HavenXia) mentioned this pull request Oct 30, 2026

[bug-bash] hack/ate-dev-env.sh.example pins CLUSTER_VERSION=1.36.3-gke.1767000, which GKE no longer offers #3371

Closed

Tim Hockin (thockin) modified the milestones: M3, v1.0.x Oct 30, 2026

Grant McCloskey (MushuEE) mentioned this pull request Oct 30, 2026

tools: remove setup-gcp and hack/teardown.sh #3505

Merged

Tim Hockin (thockin) closed this Nov 2, 2026

Max Thompson (thompsonmax) mentioned this pull request Nov 3, 2026

Document federating actor JWTs and rotating the signing key #2911

Merged

2 tasks done

Conversation

Steven Shriver (stshrive) commented Oct 28, 2026

Uh oh!

Aditya Shantanu (aditya-shantanu) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Aditya Shantanu (aditya-shantanu) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Haven Xia (HavenXia) left a comment

Choose a reason for hiding this comment

Uh oh!

Steven Shriver (stshrive) commented Oct 29, 2026

Uh oh!

Grant McCloskey (MushuEE) commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Haven Xia (HavenXia) commented Oct 29, 2026

Uh oh!

Haven Xia (HavenXia) commented Oct 29, 2026

Uh oh!

Tim Hockin (thockin) Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

Benjamin Elder (BenTheElder) Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

Benjamin Elder (BenTheElder) commented Oct 30, 2026

Uh oh!

Tim Hockin (thockin) commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tim Hockin (thockin) commented Oct 30, 2026

Uh oh!

Grant McCloskey (MushuEE) commented Oct 30, 2026

Uh oh!

Grant McCloskey (MushuEE) commented Oct 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Grant McCloskey (MushuEE) commented Oct 29, 2026 •

edited

Loading

Tim Hockin (thockin) commented Oct 30, 2026 •

edited

Loading