Repository navigation
benchmarking: stop uploading the duplicate {name}.jsonl - #3309
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 29, 2026
Merged
Conversation
The runner uploaded the same stats file twice, as stats.jsonl and as
{name}.jsonl. Nothing reads the second copy now that the data migration
is done.
Signed-off-by: Haiyan Meng <[email protected]>
haiyanmeng
force-pushed
the
remove-extra-results
branch
from
October 27, 2026 15:15
95e5663 to
5d2e6b1
Compare
haiyanmeng
marked this pull request as ready for review
October 27, 2026 15:16
haiyanmeng
added
kind/cleanup
Collaborator
|
Thanks! Benchmarking-only change, merging |
1 of 2 tasks
Dmitry Berkovich (dberkov)
pushed a commit
that referenced
this pull request
Nov 2, 2026
The locust runner uploads the same stats file twice, as `stats.jsonl`
and `{name}.jsonl`. The second copy was kept for a data migration (see
the removed TODO). Nothing in the repo reads it now.
I used Claude Code to find the duplicate upload and make the edit. I
reviewed the diff.
Signed-off-by: Haiyan Meng <[email protected]>
(cherry picked from commit 0d662b8)
Signed-off-by: Eitan Yarmush <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locust runner uploads the same stats file twice, as
stats.jsonland{name}.jsonl. The second copy was kept for a data migration (see the removed TODO). Nothing in the repo reads it now.I used Claude Code to find the duplicate upload and make the edit. I reviewed the diff.