Skip to content

[bugbash] hack/teardown.sh: add --cluster-scoped to tear down one cluster - #3296

Merged
Dmitry Berkovich (dberkov) merged 3 commits into
agent-substrate:mainfrom
HavenXia:teardown-cluster-scope
Oct 28, 2026
Merged

Dmitry Berkovich (dberkov) merged 3 commits into
agent-substrate:mainfrom
HavenXia:teardown-cluster-scope

Conversation

@HavenXia

@HavenXia Haven Xia (HavenXia) commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

hack/teardown.sh --all deletes resources that every Substrate cluster in the project shares, so cleaning up one cluster broke image pulls and snapshot transfers on the others.

Fixes #3227

  • --cluster-scoped deletes only the cluster, its buckets and the bindings on them.
  • --all still deletes everything setup-gcp created, including the dashboards, the transfer service account and the project-level IAM bindings. The usage text lists those steps as project-wide.
  • The README says to use --cluster-scoped while other clusters share the project.

Assisted by Claude Code. I reviewed the diff.

Every Substrate cluster in a project shares the dashboards, the snapshot
transfer service account and the project-level IAM bindings. setup-gcp
reuses them when they exist. --all deleted them too, which broke image
pulls and snapshot transfers on the other clusters.

--all now deletes only the cluster, its buckets and the bindings on them.
It prints how to remove the shared resources, and the project-wide steps
keep their own flags.

Signed-off-by: Haven Xia <[email protected]>
@HavenXia Haven Xia (HavenXia) added kind/docs Improvements or additions to documentation area/dev-infra labels Oct 27, 2026
@HavenXia Haven Xia (HavenXia) changed the title hack/teardown.sh: --all deletes only this cluster's resources [bugbash] hack/teardown.sh: --all deletes only this cluster's resources Oct 27, 2026
@HavenXia Haven Xia (HavenXia) added this to the v1.0.x milestone Oct 27, 2026
--all again deletes everything setup-gcp bootstrap creates, including
the project-wide dashboards, transfer service account and IAM bindings.
--cluster-scoped deletes only the cluster, its buckets and the bindings
on them, for a project where other Substrate clusters still run. The
README says when to use each.

Signed-off-by: Haven Xia <[email protected]>
@HavenXia Haven Xia (HavenXia) changed the title [bugbash] hack/teardown.sh: --all deletes only this cluster's resources [bugbash] hack/teardown.sh: add --cluster-scoped to tear down one cluster Oct 28, 2026
Comment thread README.md Resolved
@dberkov
Dmitry Berkovich (dberkov) added this pull request to the merge queue Oct 28, 2026
Merged via the queue into agent-substrate:main with commit 67c6a6b Oct 28, 2026
5 checks passed
@HavenXia
Haven Xia (HavenXia) deleted the teardown-cluster-scope branch October 28, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dev-infra kind/docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug-bash] hack/teardown.sh --all removes project-wide IAM grants and the shared transfer service account

2 participants