Repository navigation
ateworker: reuse a completed checkpoint only on the same boot - #3213
Merged
Dmitry Berkovich (dberkov) merged 3 commits intoOct 28, 2026
Merged
Dmitry Berkovich (dberkov) merged 3 commits into
Dmitry Berkovich (dberkov) merged 3 commits into
Conversation
Chenyi Wang (chw120)
requested review from
Haven Xia (HavenXia),
Michelle Au (msau42) and
Zoe Zhao (zoez7)
October 26, 2026 18:03
Chenyi Wang (chw120)
force-pushed
the
checkpoint-reuse-same-boot
branch
from
October 26, 2026 22:26
e12e5cd to
57f0261
Compare
Chenyi Wang (chw120)
added
the
prio/P0
Bowei Du (bowei)
added
area/gvisor
area/microVM
area/node
area/reliability
area/storage
kind/bug
Chenyi Wang (chw120)
force-pushed
the
checkpoint-reuse-same-boot
branch
from
October 27, 2026 22:13
57f0261 to
57d33e8
Compare
The worker does not sync the snapshot files before it records a completed checkpoint. After a node reboot, the files and the record can survive while the file contents are torn. A retry then reused them, and atelet stamped its local snapshot with the new boot ID, so nothing caught the torn files. RecordCheckpoint now records the node's boot ID, and ReuseCheckpoint skips a record from another boot. The boot ID reader moves from atelet to internal/bootid so the workers can use it. Signed-off-by: Chenyi Wang <[email protected]>
A node without a readable boot ID now fails before the worker opens its socket or starts the tunnel. Signed-off-by: Chenyi Wang <[email protected]>
Chenyi Wang (chw120)
force-pushed
the
checkpoint-reuse-same-boot
branch
from
October 28, 2026 20:53
5e6d222 to
cb9bef2
Compare
Collaborator
Author
Signed-off-by: Chenyi Wang <[email protected]>
Michelle Au (msau42)
approved these changes
Oct 28, 2026
Dmitry Berkovich (dberkov)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3015. Part of #2836.
A retried CheckpointWorkload reuses the worker's record of a completed checkpoint. The worker does not sync the snapshot files, so after a node reboot the record and the files can survive with torn contents. The retry then reused them, and atelet stamped the local snapshot with the new boot ID, so its pre-reboot check no longer catches them.
TestRecordAndReuseCheckpoint covers a record from another boot.
AI use: AI-assisted. I reviewed and tested it.