Repository navigation
benchmarking/locust: cap trial_summary actor density by live actors - #3140
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 23, 2026
Merged
Max Smythe (maxsmythe) merged 1 commit into
Max Smythe (maxsmythe) merged 1 commit into
Conversation
Locust's User Count in stats_history.csv tracks spawned VU goroutines even when CreateActor fails or wedged actors are deleted during the run. Cap peak_actors in append_trial_summary by CreateActor successes minus unretired DeleteActor requests (excluding completed TaskWallClock trajectories in sweperf) when CreateActor is present in stats.csv, and update test_live_actors_from_create_and_delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locust's
User Countinstats_history.csvtracks spawned VU goroutines even whenCreateActorfails or wedged actors are deleted during the run (for example, in resident density benchmarks where the target user count exceeds single-node capacity).append_trial_summary(benchmarking/locust/cluster_facts.py), whenCreateActoris recorded instats.csv, cappeak_actorsbyCreateActorsuccesses minus unretiredDeleteActorrequests (excluding completedTaskWallClocktrajectories insweperfthat retire their actor before starting a fresh one;stats.csvis written before boomer's shutdownDeleteActorsweep).test_live_actors_from_create_and_deleteinbenchmarking/locust/unit_tests/test_cluster_facts.pyto cover warmup retry deletes, 100%CreateActorfailures, partial actor survival, andsweperftrajectory retirements.Testing
python3 -m unittest discover -s benchmarking/locust/unit_tests -p 'test_*.py'