Repository navigation
Reject WorkerPool names longer than 63 characters - #3136
Merged
Tim Hockin (thockin) merged 1 commit intoOct 23, 2026
Merged
Conversation
haiyanmeng
requested review from
Benjamin Elder (BenTheElder) and
Julian Gutierrez Oschmann (juli4n)
October 22, 2026 21:40
haiyanmeng
marked this pull request as ready for review
October 22, 2026 21:40
haiyanmeng
added
area/node
kind/cleanup
haiyanmeng
force-pushed
the
workerpool-name-max-63
branch
from
October 22, 2026 23:18
7e5bec6 to
7011a53
Compare
Davanum Srinivas (dims)
approved these changes
Oct 23, 2026
haiyanmeng
force-pushed
the
workerpool-name-max-63
branch
from
October 23, 2026 12:19
7011a53 to
6c2553c
Compare
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
This solution LGTM, Benjamin Elder (@BenTheElder) mentioned he was just thinking through it so I'll wait for him to LGTM as well
Collaborator
|
let's ship it, cc Julian Gutierrez Oschmann (@juli4n) have we thought about if this is the right way to expose this info? |
Benjamin Elder (BenTheElder)
approved these changes
Oct 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
Worker pods and the pool's NetworkPolicy use the pool name as the ate.dev/worker-pool label value, which Kubernetes caps at 63 characters. A longer name was accepted, and then every reconcile failed.
haiyanmeng
force-pushed
the
workerpool-name-max-63
branch
from
October 23, 2026 22:02
6c2553c to
0d23118
Compare
Tim Hockin (thockin)
enabled auto-merge
October 23, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WorkerPool name can be up to 253 characters, but
ate-controllerputs it in theate.dev/worker-poollabel on the worker pods and the pool's NetworkPolicy. Label values are capped at 63 characters. A longer name is accepted, and then every reconcile of the pool fails, with the error only in the controller log.The CRD now rejects names longer than 63 characters at create time. Came up while reviewing #3130.
AI use: Claude Code wrote the change, the test rows and this description. I reviewed them.