Repository navigation
correct the minimum kernel for the image cache: Linux 6.7, or 6.6.23 - #3128
Merged
Haven Xia (HavenXia) merged 2 commits intoOct 22, 2026
Merged
Haven Xia (HavenXia) merged 2 commits into
Haven Xia (HavenXia) merged 2 commits into
Conversation
it landed in 6.7 and was backported to 6.6.23, not 6.5
Benjamin Elder (BenTheElder)
added
kind/docs
Benjamin Elder (BenTheElder)
marked this pull request as ready for review
October 22, 2026 20:11
Collaborator
Author
|
also: dropped the COS references, this is generic code, not GKE specific |
Haven Xia (HavenXia)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #2963 (review)
The imagecache comment and README say the minimum kernel is 6.5, but overlayfs's
lowerdir+landed in 6.7 (24e16e385f22, "ovl: add support for appending lowerdirs one by one"), and was backported to 6.6.y in v6.6.23:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/overlayfs/params.c?h=v6.7#n148
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/fs/overlayfs/params.c?h=v6.6.23#n148
6.5 had a different append syntax,
lowerdir=:dir, but it was disabled before 6.6 shipped (beae836e9c61, "ovl: temporarily disable appending lowedirs") and we don't use it:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/overlayfs/params.c?h=v6.6#n375
AI use: AI-assisted, I reviewed it.