Repository navigation
benchmarking: rename --lifecycle-mode values to sync/async and default to async - #3097
Merged
Zoe Zhao (zoez7) merged 1 commit intoOct 22, 2026
Conversation
…t to async Rename the --lifecycle-mode choices from suspend and pause to sync and async, and switch the default in lifecycle_mode.py and the boomer agentsession, ateenv, glutton, durdir, and sweperf user classes to async (DURABILITY_MODE_ASYNCHRONOUS) to match Control.SuspendActor's default.
Chenyi Wang (chw120)
force-pushed
the
default-lifecycle-mode-pause
branch
from
October 21, 2026 23:55
7faac0e to
e9abf98
Compare
Chenyi Wang (chw120)
requested review from
Max Smythe (maxsmythe) and
Zoe Zhao (zoez7)
October 21, 2026 23:57
Parnika Mandewalkar (pmandewalkar)
left a comment
Parnika Mandewalkar (pmandewalkar)
left a comment
Contributor
There was a problem hiding this comment.
nit: test names still say pause, can we make that _async? Max Smythe (@maxsmythe)
Collaborator
Author
I thought about renaming them, but the test name is used as the GCS output prefix and BigQuery table name for the dashboard—renaming it would break historical data continuity unless we also migrate the GCS folders and recreate the BigQuery tables, so I left the names as-is. |
Parnika Mandewalkar (pmandewalkar)
approved these changes
Oct 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the
--lifecycle-modechoices fromsuspendandpausetosyncandasync, and switch the default inlifecycle_mode.pyand the boomeragentsession,ateenv,glutton,durdir, andsweperfuser classes toasync(DURABILITY_MODE_ASYNCHRONOUS) to matchControl.SuspendActor's default (#2813).