Repository navigation
glutton: run the RunScript timing tests on a synctest bubble - #3090
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 22, 2026
Merged
Max Smythe (maxsmythe) merged 1 commit into
Max Smythe (maxsmythe) merged 1 commit into
Conversation
TestRunScriptLoopsUntilTheBudget counted 3 passes on a slow CI machine: the disk writes between sleeps pushed the loop past its budget before the fourth pass. On the bubble's clock a pass costs only its sleep, so the pass counts and elapsed times are exact and the tests assert them.
Bowei Du (bowei)
approved these changes
Oct 21, 2026
Collaborator
|
This is a unit test fix. |
Bowei Du (bowei)
enabled auto-merge
October 21, 2026 21:33
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRunScriptLoopsUntilTheBudget counted 3 passes on a slow CI machine: the disk writes between sleeps pushed the loop past its budget before the fourth pass. On the bubble's clock a pass costs only its sleep, so the pass counts and elapsed times are exact and the tests assert them.
This fixes a test flake.
Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)
Fixes #
AI use:
Code written with help of AI. I have reviewed it.