Repository navigation
atenet-egress: log access log paths without the query string - #3077
Merged
Lior Lieberman (LiorLieberman) merged 1 commit intoOct 21, 2026
Merged
Lior Lieberman (LiorLieberman) merged 1 commit into
Lior Lieberman (LiorLieberman) merged 1 commit into
Conversation
The mitm and cleartext legs' access logs printed the path with %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%, which includes the query. The mitm leg logs requests the gateway has decrypted, and actor traffic can carry credentials in the query (API keys, signed URL tokens, OAuth codes). These lines go to stdout and the cluster log backend for every failed request and a 1% sample of the rest. Use %PATH(NQ:ORIG_OR_PATH)%, the same original-or-path choice without the query, which the router's access log already does for this reason. TestEgressManifestsLogPathsWithoutTheQuery fails if any access log format in the egress bootstrap prints the path with its query.
Da Huang (git286)
requested review from
Lior Lieberman (LiorLieberman),
Bowei Du (bowei) and
haiyanmeng
October 21, 2026 18:28
Da Huang (git286)
added
area/security
Lior Lieberman (LiorLieberman)
approved these changes
Oct 21, 2026
Lior Lieberman (LiorLieberman)
left a comment
Lior Lieberman (LiorLieberman)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mitm and cleartext legs' access logs printed the path with %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%, which includes the query. The mitm leg logs requests the gateway has decrypted, and actor traffic can carry credentials in the query (API keys, signed URL tokens, OAuth codes). These lines go to stdout and the cluster log backend for every failed request and a 1% sample of the rest.
Use %PATH(NQ:ORIG_OR_PATH)%, the same original-or-path choice without the query, which the router's access log already does for this reason.
TestEgressManifestsLogPathsWithoutTheQuery fails if any access log format in the egress bootstrap prints the path with its query.
Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)
Fixes #3076
AI use: