Repository navigation
atelet: return Canceled when Run or Restore fails to reset actor dirs - #3063
Merged
Luiz Oliveira (laoj2) merged 1 commit intoOct 22, 2026
Merged
Conversation
Zoe Zhao (zoez7)
marked this pull request as ready for review
October 21, 2026 16:16
Zoe Zhao (zoez7)
force-pushed
the
atelet-reset-dirs-canceled
branch
from
October 21, 2026 22:11
faf1bd1 to
254d5f8
Compare
| t.Run(tc.name, func(t *testing.T) { | ||
| if err := tc.call(t); status.Code(err) != codes.Canceled { | ||
| t.Errorf("%s = %v (code %s), want %s", tc.name, err, status.Code(err), codes.Canceled) | ||
| } |
Collaborator
There was a problem hiding this comment.
can we add a retry call, where with now files that will make resetActorDirsKeepingVolumes succeed to make sure the retries are safe?
A ResetActorDirsKeepingVolumes failure points at atelet or the node's disk, not the actor. It returned code Unknown, so ate-api-server crashed the actor. Return Canceled so ate-api-server retries instead.
Zoe Zhao (zoez7)
force-pushed
the
atelet-reset-dirs-canceled
branch
from
October 22, 2026 20:30
f4eb90d to
c32bb96
Compare
Luiz Oliveira (laoj2)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resetActorDirs failure is an error related to atelet or the node's disk, not the actor.
Return Canceled so ate-api-server does not crash the actor.
AI use: AI-assisted, I reviewed and tested it.