Repository navigation
manifests: Give podcertificate-controller its own ServiceAccount - #3059
Merged
Eitan Yarmush (EItanya) merged 1 commit intoOct 22, 2026
Conversation
The Deployment and both of its RBAC bindings used the namespace's default ServiceAccount, so any pod in podcertificate-controller-system without a serviceAccountName inherited sign and attest on every Substrate signer. Add ServiceAccount/podcertificate-controller and point the Deployment, the ClusterRoleBinding and the coordinator RoleBinding at it.
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 22, 2026
Collaborator
|
LGTM. Security fix: Eitan Yarmush (@EItanya) Benjamin Elder (@BenTheElder) for merge approval. |
Eitan Yarmush (EItanya)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deployment and both of its RBAC bindings used the namespace's default ServiceAccount, so any pod in podcertificate-controller-system without a serviceAccountName inherited sign and attest on every Substrate signer.
Add ServiceAccount/podcertificate-controller and point the Deployment, the ClusterRoleBinding and the coordinator RoleBinding at it.
Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)
Fixes part of #2936
AI use: AI-assisted, I reviewed and tested it.