Repository navigation
atecontroller: Limit the Secrets read to the egress MITM CA pool - #3036
Merged
Eitan Yarmush (EItanya) merged 1 commit intoOct 22, 2026
Merged
Eitan Yarmush (EItanya) merged 1 commit into
Eitan Yarmush (EItanya) merged 1 commit into
Conversation
The controller reads one Secret, egress-mitm-ca-pool in ate-system, but its RBAC marker granted get, list and watch on every Secret in the cluster. Add namespace and resourceNames to the marker. The rule moves from the ClusterRole to the ate-system Role, which is already bound.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 22, 2026
Collaborator
|
This change LGTM. Benjamin Elder (@BenTheElder) Eitan Yarmush (@EItanya) Tim Hockin (@thockin) for merge approval. |
Eitan Yarmush (EItanya)
approved these changes
Oct 22, 2026
Collaborator
|
LGTM |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 22, 2026
Merged
1 of 2 tasks
Quentin Bisson (QuentinBisson)
pushed a commit
to giantswarm/substrate
that referenced
this pull request
Nov 5, 2026
…nt-substrate#3036) The controller reads one Secret, egress-mitm-ca-pool in ate-system, but its RBAC marker granted get, list and watch on every Secret in the cluster. Add namespace and resourceNames to the marker. The rule moves from the ClusterRole to the ate-system Role, which is already bound. <!-- The PR title becomes the release note. Write it for users. --> Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.) Fixes part of agent-substrate#2936 <!-- e.g. "AI-assisted, I reviewed and tested it." No AI co-author trailers. --> AI use: I-assisted, I reviewed and tested it. <!-- Breaking change? Describe what users must do on upgrade and ask for the `breaking-change` label. --> - [x] Tests pass - [ ] Docs updated (cherry picked from commit 8076520)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller reads one Secret, egress-mitm-ca-pool in ate-system, but its RBAC marker granted get, list and watch on every Secret in the cluster. Add namespace and resourceNames to the marker. The rule moves from the ClusterRole to the ate-system Role, which is already bound.
Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)
Fixes part of #2936
AI use: I-assisted, I reviewed and tested it.