Repository navigation
manifests: Run control plane containers as non-root - #3028
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoOct 25, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
LGTM, agree with all these changes. I think it would be better to get these in before GA because clawing back permissions is always hard. It's much easier if they are minimal from the start. |
Mike Dickey (mikedickey)
force-pushed
the
nonroot-images
branch
from
October 23, 2026 15:57
9cdfd04 to
ee34d9e
Compare
ko built every image on a base that runs as root, so runAsNonRoot would have failed every pod with CreateContainerConfigError. Switch defaultBaseImage to static-debian13:nonroot, pinned by digest, and set runAsNonRoot on the control plane containers. Also set allowPrivilegeEscalation: false and drop all capabilities on containers that lacked them. ate-api-server keeps NET_BIND_SERVICE for :443. The envoy container in atenet-router sets runAsUser: 65532 because its image has no USER. ate-controller gets a read-only root filesystem. atelet and its objectstore-plugin sidecar stay root and only get allowPrivilegeEscalation: false.
Mike Dickey (mikedickey)
force-pushed
the
nonroot-images
branch
from
October 24, 2026 21:25
ee34d9e to
2024af6
Compare
Benjamin Elder (BenTheElder)
approved these changes
Oct 25, 2026
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
thanks!
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ko built every image on a base that runs as root, so runAsNonRoot would have failed every pod with CreateContainerConfigError. Switch defaultBaseImage to static-debian13:nonroot, pinned by digest, and set runAsNonRoot on the control plane containers.
Also set allowPrivilegeEscalation: false and drop all capabilities on containers that lacked them. ate-api-server keeps NET_BIND_SERVICE for :443. The envoy container in atenet-router sets runAsUser: 65532 because its image has no USER. ate-controller gets a read-only root filesystem. atelet and its objectstore-plugin sidecar stay root and only get allowPrivilegeEscalation: false.
Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)
Fixes part of #2936
AI use: Ai-assisted, I reviewed and tested it.