Repository navigation
Components no longer warn about a partial telemetry resource at startup - #2998
Merged
Jeff Luo (JeffLuoo) merged 2 commits intoOct 21, 2026
Merged
Jeff Luo (JeffLuoo) merged 2 commits into
Jeff Luo (JeffLuoo) merged 2 commits into
Conversation
The resource used semconv v1.40.0 while the SDK's own detector now uses v1.43.0, so every component logged "partial telemetry resource ... conflicting Schema URL" at startup and its resource lost the schema URL. The attributes were all kept. Use v1.43.0, and test that the resource's schema URL matches the SDK's, so the next SDK upgrade fails a test rather than warning in every pod.
Tim Bai (baizhenyu)
requested review from
Jeff Luo (JeffLuoo) and
Da Huang (git286)
October 20, 2026 20:26
Jeff Luo (JeffLuoo)
left a comment
Jeff Luo (JeffLuoo)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix. The change in serverboot is correct, and go test -race ./internal/serverboot/ passes for me at this commit. I have one comment: boomer-worker has the same bug.
boomer-worker's tracer resource had the same semconv v1.40.0 pin as serverboot, so it logged the same "conflicting Schema URL" warning and lost the schema URL. Move it to v1.43.0, and pull the resource into newResource so a test can check its schema URL matches the SDK's, as serverboot's does.
Tim Bai (baizhenyu)
added
kind/bug
Jeff Luo (JeffLuoo)
approved these changes
Oct 21, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every component logged this at startup:
serverboot.newResourcesets the resource's schema with semconv v1.40.0, while the vendored SDK's own resource detector now uses v1.43.0. The merge then drops the schema URL. All attributes were kept: on ate-dev, atelet'starget_infostill hadservice.*andk8s.*. Only the schema URL was lost, and the warning made the resource look partial.This moves
serverbootto semconv v1.43.0, and adds a check toTestNewResourceDefaultsthat the resource's schema URL equals the SDK's (resource.Default().SchemaURL()). With the old import, the test fails withschema URL = "", want the SDK's "https://opentelemetry.io/schemas/1.43.0", so the next SDK upgrade that moves its semconv version fails a test instead of warning in every pod.boomer-worker's tracer resource had the same pin (
internal/benchmarking/boomer/trace); it gets the same fix, its resource moves intonewResource, and a new test checks its schema URL the same way. The only other resource with a pinned schema, inateclient, runs no detectors, so it cannot conflict.Found while testing on ate-dev.