Repository navigation
hardening: fix submounts of read-only image volumes being writable - #2944
Merged
Zoe Zhao (zoez7) merged 6 commits intoOct 20, 2026
Merged
Conversation
Benjamin Elder (BenTheElder)
added
area/security
mount_setattr checks privilege before the path, so unprivileged it gets EPERM, not ENOENT. the statfs error it covered is gone
Haven Xia (HavenXia)
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image volumes were only read-only at the top mount. Mounts nested under them, or mounted under the source later, stayed writable. Current image volumes have no submounts, so this is hardening.
Fixes #2933
The new root-gated test cases each fail without their fix. I ran them locally as root.
AI use: AI-assisted, I reviewed and tested it.