Repository navigation
atelet: Serialize lifecycle RPCs per actor - #2890
Merged
Zoe Zhao (zoez7) merged 1 commit intoOct 19, 2026
Merged
Conversation
Atelet now runs at most one lifecycle RPC per actor at a time. Run, Restore, Checkpoint, PromoteSnapshot, DetachActor, and Terminate wait their turn for the actor. Before, Terminate could forget an actor and delete its local snapshots and directories while a Checkpoint or Restore of the actor was still using them, and a Checkpoint that committed afterward recreated snapshot state for the terminated actor. Terminate waits for any in-flight RPC for that actor to finish before forgetting its snapshot state and removing its local snapshots and actor directories. With RPCs serialized at the atelet boundary, snapshottracker only coordinates background uploads, detaches, and reports against the active RPC.
Michelle Au (msau42)
requested review from
Dmitry Berkovich (dberkov) and
Zoe Zhao (zoez7)
October 19, 2026 18:12
This was referenced Oct 19, 2026
Zoe Zhao (zoez7)
enabled auto-merge
October 19, 2026 20:25
Zoe Zhao (zoez7)
approved these changes
Oct 19, 2026
| holdStart // Run or Restore | ||
| holdCheckpoint // Checkpoint | ||
| holdPromote // PromoteSnapshot | ||
| ) |
Collaborator
There was a problem hiding this comment.
Should we also prevent a Terminate RPC to happen in parallel with background detach? (i.e. let the background upload finish, before handling the Terminate RPC)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atelet now runs at most one lifecycle RPC per actor at a time. Run, Restore, Checkpoint, PromoteSnapshot, DetachActor, and Terminate wait their turn for the actor.
Before, Terminate could forget an actor and delete its local snapshots and directories while a Checkpoint or Restore of the actor was still using them, and a Checkpoint that committed afterward recreated snapshot state for the terminated actor.
Terminate waits for any in-flight RPC for that actor to finish before forgetting its snapshot state and removing its local snapshots and actor directories. With RPCs serialized at the atelet boundary, snapshottracker only coordinates background uploads, detaches, and reports against the active RPC.
Part of #2069, #2571, #2836