Repository navigation
Fake data plane installs no longer fail at startup on the --preview flag - #2884
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 19, 2026
Conversation
ate-setup gives every substrate binary it installs a --preview argument, and neither fake binary defined the flag, so both exited at start with "unknown flag: --preview" and no --fake-data-plane install came up. Define it in both and initialize the preview gates from it, as the other control-plane binaries do.
haiyanmeng
requested review from
Julian Gutierrez Oschmann (juli4n),
Max Smythe (maxsmythe) and
Tim Hockin (thockin)
October 19, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ate-setuppasses a--previewargument to every substrate binary it installs. Neither fake-atelet nor fake-workersync defined that flag, so both exited at startup withunknown flag: --preview, and a--fake-data-planeinstall never came up.This defines
--previewin both binaries and initializes the preview gates from it, the same way the other control-plane binaries do.