Skip to content

TestSyncer_Lifecycle no longer flakes on a worker that is still UNAVAILABLE - #2824

Merged
Michelle Au (msau42) merged 1 commit into
agent-substrate:mainfrom
ericcurtin:syncer-lifecycle-flake
Oct 20, 2026
Merged

Michelle Au (msau42) merged 1 commit into
agent-substrate:mainfrom
ericcurtin:syncer-lifecycle-flake

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Part of #799.

The test could read the worker after registration but before it was marked ACTIVE. It failed twice on main this week.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

The syncer registers a worker UNAVAILABLE and marks it ACTIVE in a later call, so waiting for it to exist could read it in between.
@bowei Bowei Du (bowei) added area/api-machinery area/tests Enhancing / fixing test coverage. kind/bug Something isn't working / bugfixes labels Oct 19, 2026
@msau42
Michelle Au (msau42) added this pull request to the merge queue Oct 20, 2026
Merged via the queue into agent-substrate:main with commit 0d7f0d3 Oct 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api-machinery area/tests Enhancing / fixing test coverage. kind/bug Something isn't working / bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants