Repository navigation
gvisor SandboxConfig no longer accepts a bare runsc asset - #2798
Merged
Dmitry Berkovich (dberkov) merged 2 commits intoOct 17, 2026
Merged
Dmitry Berkovich (dberkov) merged 2 commits into
Dmitry Berkovich (dberkov) merged 2 commits into
Conversation
Contributor
Author
|
Could a maintainer add the |
Contributor
Author
|
Dmitry Berkovich (@dberkov) Shrutiya Mohan (@shrutiyam-glitch) PTAL when you get a chance. Thank you! |
Collaborator
done |
| // and binaries keyed first by architecture (GOARCH) and then by asset name. | ||
| // atelet's backend code interprets the asset names (gVisor expects "gvisor", | ||
| // the release tarball; legacy "runsc", a bare binary, is still accepted). | ||
| // the release tarball). |
Collaborator
There was a problem hiding this comment.
🤖 nit 🟢 – The matching clause in the worker proto still lists the bare asset: internal/proto/ateworkerpb/ateworker.proto:222 says the names are "gvisor" and "runsc" for gVisor. Drop "runsc" there too and regenerate ateworker.pb.go (its copy is at line 483).
Dmitry Berkovich (dberkov)
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
A gvisor SandboxConfig must give every architecture the
gvisorrelease tarball asset. A barerunscasset is now rejected. Replace it with the tarball.Fixes #2697
Removes the bare
runscasset from atelet and the admission policy, and moves the atelet tests onto the gVisor release tarball.