Repository navigation
ateapi: carry the golden actor's crash message into the template status - #2644
Merged
Dmitry Berkovich (dberkov) merged 1 commit intoOct 28, 2026
Merged
Conversation
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
marked this pull request as ready for review
October 14, 2026 14:13
Davanum Srinivas (dims)
force-pushed
the
template-crash-reason
branch
4 times, most recently
from
October 18, 2026 21:48
9f9dbef to
e358902
Compare
Bowei Du (bowei)
added
area/api-machinery
kind/feature
Davanum Srinivas (dims)
force-pushed
the
template-crash-reason
branch
2 times, most recently
from
October 21, 2026 11:01
1618dd1 to
1fbc8ee
Compare
1 of 2 tasks
Davanum Srinivas (dims)
force-pushed
the
template-crash-reason
branch
7 times, most recently
from
October 27, 2026 12:43
4d26e7c to
be52ed3
Compare
A crashed golden left the template with "golden actor crashed before its snapshot was taken" and nothing else; the reason sat in the actor's crash status. Append it, so a bad image volume or a failed restore is readable from the template. Signed-off-by: Davanum Srinivas <[email protected]>
Davanum Srinivas (dims)
force-pushed
the
template-crash-reason
branch
from
October 28, 2026 11:03
be52ed3 to
9d1d939
Compare
haiyanmeng
approved these changes
Oct 28, 2026
haiyanmeng
requested review from
Julian Gutierrez Oschmann (juli4n) and
Luiz Oliveira (laoj2)
October 28, 2026 19:05
Luiz Oliveira (laoj2)
approved these changes
Oct 28, 2026
Collaborator
Dmitry Berkovich (dberkov)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the actor used to build a template crashes, the template status now includes the actor's crash message. This makes failures such as a bad image volume or failed restore visible directly on the template.
Overlaps with #2453, which also adds crash details to template failures.
go test -race ./cmd/ateapi/internal/controlapi/;go vet.