Repository navigation
Changed SandboxClass from enum to string to allow extensibility - #2586
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoOct 14, 2026
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Julian Gutierrez Oschmann (juli4n) merged 1 commit into
Conversation
Luiz Oliveira (laoj2)
requested a review
from Julian Gutierrez Oschmann (juli4n)
October 13, 2026 18:43
Luiz Oliveira (laoj2)
added
area/api
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 13, 2026
| path: egress-trust-bundle/trust-bundle.pem | ||
| sandboxConfig: | ||
| sandboxClass: SANDBOX_CLASS_GVISOR | ||
| sandboxClass: gvisor |
Collaborator
There was a problem hiding this comment.
aside: we want to remove this field from actortemplate, cc Zoe Zhao (@zoez7)
Collaborator
There was a problem hiding this comment.
Yes, will remove it this week.
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
needs rebase
Luiz Oliveira (laoj2)
force-pushed
the
sandbox-config
branch
from
October 14, 2026 13:39
033f25a to
7f41d73
Compare
Luiz Oliveira (laoj2)
requested review from
Benjamin Elder (BenTheElder) and
Julian Gutierrez Oschmann (juli4n)
October 14, 2026 13:45
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Oct 14, 2026
Julian Gutierrez Oschmann (juli4n)
enabled auto-merge
October 14, 2026 14:00
Luiz Oliveira (laoj2)
force-pushed
the
sandbox-config
branch
3 times, most recently
from
October 14, 2026 17:22
283ea89 to
1d7823f
Compare
Julian Gutierrez Oschmann (juli4n)
previously approved these changes
Oct 14, 2026
Luiz Oliveira (laoj2)
removed this pull request from the merge queue due to a manual request
Oct 14, 2026
Luiz Oliveira (laoj2)
force-pushed
the
sandbox-config
branch
from
October 14, 2026 17:50
1d7823f to
8fe271d
Compare
Julian Gutierrez Oschmann (juli4n)
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
An ActorTemplate's
sandboxConfig.sandboxClassis now a string,gvisorormicrovm, the same values the WorkerPool and SandboxConfig CRDs use. TheSANDBOX_CLASS_GVISORandSANDBOX_CLASS_MICROVMspellings are rejected.To upgrade:
SANDBOX_CLASS_GVISORwithgvisorandSANDBOX_CLASS_MICROVMwithmicrovm.pkg/proto/ateapipb: theSandboxClassenum is removed andSandboxConfig.SandboxClassis astring.sandboxClass, because the stored enum value does not decode into the new string field. Templates are immutable, so delete them and their actors before upgrading and recreate them afterwards.SANDBOX CLASScolumn ofkubectl ate get actortemplatesnow printsgvisorormicrovm.Fixes #2406