Repository navigation
Drop per-pod server.address label from rpc.client.call.duration metrics - #2576
Merged
Jeff Luo (JeffLuoo) merged 2 commits intoOct 14, 2026
Merged
Jeff Luo (JeffLuoo) merged 2 commits into
Jeff Luo (JeffLuoo) merged 2 commits into
Conversation
otelgrpc sets server.address on rpc.client.call.duration from the remote address of the client connection. atelet calls each ateom on a socket path that holds the worker pod UID, and a TCP client gets the IP address of one server pod. Thus the key had one value for each pod, and the number of series grew with the number of worker pods. newMeterProvider now adds a View that removes server.address from each instrument of the otelgrpc scope. Every component builds its MeterProvider there, so the View covers each client. The scope match also covers the older histogram that otelgrpc records when OTEL_SEMCONV_STABILITY_OPT_IN asks for it. server.port stays, because it has one value for each service. The registry no longer lists server.address on rpc.client.call.duration, and the note of the histogram says why the key is absent.
Krisztian F (krisztianfekete)
left a comment
Krisztian F (krisztianfekete)
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM, once the lint error is fixed!
attribute.Value.Emit is deprecated, and staticcheck fails on it.
Collaborator
Author
|
fixed |
Krisztian F (krisztianfekete)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otelgrpcsetsserver.addressonrpc.client.call.durationfrom the remote address of the client connection:ateletdials eachateomover a Unix socket path containing the worker pod UID, and TCP clients record the IP address of an individual server pod. This produced oneserver.addressvalue per pod, causing metric series cardinality to grow with worker pod count and churn.Viewinserverboot.newMeterProviderthat stripsserver.addressfrom all instruments in theotelgrpcscope while keepingserver.port(one value per service).server.addressfromdocs/metrics/registry/metrics.yamlanddocs/metrics/substrate.yaml, and document the view onrpc.client.call.duration.Fixes #2556