Repository navigation
Router status private - #2573
Merged
Lior Lieberman (LiorLieberman) merged 3 commits intoOct 13, 2026
Merged
Lior Lieberman (LiorLieberman) merged 3 commits into
Lior Lieberman (LiorLieberman) merged 3 commits into
Conversation
Bind the unauthenticated status dashboard to loopback and remove its port from the router Service to prevent other pods from reading recent requests and process configuration. Retain diagnostic access through pod port-forwarding and document health checks through the existing metrics listener.
The router Service no longer publishes the status port, so the parking suite's port-forward to the Service failed with "service atenet-router has no port 4040". Forward to the status container port on a ready router pod instead, as kubectl port-forward deployment/atenet-router does.
Collaborator
There was a problem hiding this comment.
Same comments I posted in #2297
In manifests/ate-install/atenet-router.yaml (lines 295–296), the Deployment still declares - name: status / containerPort: 4040. Nothing listens on the pod IP at that port now, so a PodMonitor, NetworkPolicy, or health check using the named port gets a refused connection. Please remove the entry (matching --port-xds noted at lines 290–291 and atenet-egress.yaml), or add a comment that the port is loopback-only.
Bind the status listener before any background server starts, so a bad --status-address fails startup cleanly. Point the health-check docs and flag help at the health listener (:9091). Drop the status container port, which nothing on the pod IP serves anymore. Test the status address and port the manifest actually configures, and share the manifest decoding between the router's manifest tests.
Jeff Luo (JeffLuoo)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up #2297 from aiqubits, rebased on main, with the e2e failure fixed.
The router's unauthenticated /statusz dashboard shows recent cross-tenant requests, worker destinations, and process configuration to any pod that can reach it. This binds it to 127.0.0.1 by default through a new --status-address flag and removes its port from the router Service. Admins can still get to it with kubectl -n ate-system port-forward deployment/atenet-router 4040:4040.
On top of the original change, the e2e parking suite now port-forwards to the status port on a router pod rather than the Service, since the Service no longer publishes it.
Breaking change
GKE HealthCheckPolicy configs using port 4040 and /statusz should move to port 9091 and /readyz. The router Deployment no longer declares the status container port either.
Fixes #2275