Repository navigation
Add actor egress benchmarking tool - #2505
Merged
Lior Lieberman (LiorLieberman) merged 7 commits intoOct 12, 2026
Merged
Lior Lieberman (LiorLieberman) merged 7 commits into
Lior Lieberman (LiorLieberman) merged 7 commits into
Conversation
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Lior Lieberman (LiorLieberman)
left a comment
Collaborator
There was a problem hiding this comment.
looks good overall.
Bowei Du (@bowei) Yufan Su (@yufan-su) can you please take a look?
| | `demo.counter.storageClass` | `STORAGE_CLASS` | `--storage-class` | `standard` | `deploy demo counter` | | ||
| | `demo.counter.withExternalVolume` | `ATE_DEMO_COUNTER_WITH_EXTERNAL_VOLUME` | `--with-external-volume` | `false` | `deploy demo counter` | | ||
| | `docker.buildFlags` | `DOCKER_BUILD_FLAGS` | `--docker-build-flags` | — | (global) | | ||
| | `envoyConcurrency` | `ATE_ENVOY_CONCURRENCY` | `--envoy-concurrency` | `0` | (global) | |
Collaborator
There was a problem hiding this comment.
do we need this for any install? or is it just for testing? if its just for testing, should we prefix it with "e2e" or something?
Collaborator
Author
There was a problem hiding this comment.
Mostly for testing.
Collaborator
There was a problem hiding this comment.
lets prefix with e2e then?
Lior Lieberman (LiorLieberman)
previously approved these changes
Oct 12, 2026
Lior Lieberman (LiorLieberman)
left a comment
Collaborator
There was a problem hiding this comment.
approved from my side - would want bowei or yufan to take a quick look. Would be great if you prefix the setting of concurrency with e2e
Signed-off-by: Yan Avlasov <[email protected]>
Lior Lieberman (LiorLieberman)
approved these changes
Oct 12, 2026
Lior Lieberman (LiorLieberman)
enabled auto-merge
October 12, 2026 17:58
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
Merged
via the queue into
agent-substrate:main
with commit Oct 12, 2026
052c348
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tool for benchmarking Substrate egress.